refactor: architecture -> arch

Author: satya164

packages/create-react-native-library/src/index.ts

@@ -133,8 +133,8 @@ const LANGUAGE_CHOICES: {
   },
 ];
 
-const NEWARCH_DESCRIPTION = 'requires new architecture (experimental)';
-const BACKCOMPAT_DESCRIPTION = 'supports new architecture (experimental)';
+const NEWARCH_DESCRIPTION = 'requires new arch (experimental)';
+const BACKCOMPAT_DESCRIPTION = 'supports new arch (experimental)';
 
 const TYPE_CHOICES: {
   title: string;
@@ -444,7 +444,7 @@ async function create(argv: yargs.Arguments<any>) {
   }
 
   const moduleType = type.startsWith('view-') ? 'view' : 'module';
-  const architecture =
+  const arch =
     type === 'module-new' || type === 'view-new'
       ? 'new'
       : type === 'module-mixed' || type === 'view-mixed'
@@ -488,7 +488,7 @@ async function create(argv: yargs.Arguments<any>) {
       package_cpp: pack.replace(/\./g, '_'),
       identifier: slug.replace(/[^a-z0-9]+/g, '-').replace(/^-/, ''),
       native: languages !== 'js',
-      architecture,
+      arch,
       cpp: languages === 'cpp',
       kotlin: languages === 'kotlin-objc' || languages === 'kotlin-swift',
       swift: languages === 'java-swift' || languages === 'kotlin-swift',
@@ -541,7 +541,7 @@ async function create(argv: yargs.Arguments<any>) {
     type: example,
     dest: folder,
     projectName: options.project.name,
-    architecture,
+    arch,
     reactNativeVersion,
   });
 
@@ -561,9 +561,9 @@ async function create(argv: yargs.Arguments<any>) {
     await copyDir(NATIVE_COMMON_FILES, folder);
 
     if (moduleType === 'module') {
-      await copyDir(NATIVE_FILES[`${moduleType}_${architecture}`], folder);
+      await copyDir(NATIVE_FILES[`${moduleType}_${arch}`], folder);
     } else {
-      await copyDir(NATIVE_FILES[`${moduleType}_${architecture}`], folder);
+      await copyDir(NATIVE_FILES[`${moduleType}_${arch}`], folder);
     }
 
     if (options.project.swift) {
@@ -572,11 +572,11 @@ async function create(argv: yargs.Arguments<any>) {
       if (moduleType === 'module') {
         await copyDir(OBJC_FILES[`${moduleType}_common`], folder);
       } else {
-        await copyDir(OBJC_FILES[`view_${architecture}`], folder);
+        await copyDir(OBJC_FILES[`view_${arch}`], folder);
       }
     }
 
-    const templateType = `${moduleType}_${architecture}` as const;
+    const templateType = `${moduleType}_${arch}` as const;
 
     if (options.project.kotlin) {
       await copyDir(KOTLIN_FILES[templateType], folder);

packages/create-react-native-library/src/utils/generateExampleApp.ts

@@ -30,13 +30,13 @@ export default async function generateExampleApp({
   type,
   dest,
   projectName,
-  architecture,
+  arch,
   reactNativeVersion = 'latest',
 }: {
   type: 'expo' | 'native';
   dest: string;
   projectName: string;
-  architecture: 'new' | 'mixed' | 'legacy';
+  arch: 'new' | 'mixed' | 'legacy';
   reactNativeVersion?: string;
 }) {
   const directory = path.join(dest, 'example');
@@ -100,7 +100,7 @@ export default async function generateExampleApp({
   );
 
   // If the library is on new architecture, enable new arch for iOS and Android
-  if (architecture === 'new') {
+  if (arch === 'new') {
     // Android
     // Change newArchEnabled=false to newArchEnabled=true in example/android/gradle.properties
     const gradleProperties = await fs.readFile(

packages/create-react-native-library/templates/common/$package.json

@@ -156,7 +156,7 @@
         }
       ]
     ]
-<% if (project.architecture === "new") { -%>
+<% if (project.arch === "new") { -%>
   },
   "codegenConfig": {
     "name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec",

packages/create-react-native-library/templates/common/CONTRIBUTING.md

@@ -34,7 +34,7 @@ To run the example app on iOS:
 yarn example ios
 ```
 
-<% if (project.architecture == 'mixed') { -%>
+<% if (project.arch === 'mixed') { -%>
 By default, the example is configured to build with the old architecture. To run the example with the new architecture, you can do the following:
 
 1. For Android, run:
@@ -57,7 +57,7 @@ yarn clean
 ```
 
 <% } -%>
-<% if (project.architecture === 'new' || project.architecture == 'mixed') { -%>
+<% if (project.arch === 'new' || project.arch === 'mixed') { -%>
 To confirm that the app is running with the new architecture, you can check the Metro logs for a message like this:
 
 ```sh
@@ -100,6 +100,7 @@ To edit the Objective-C or Swift files, open `example/ios/<%- project.name -%>Ex
 To edit the Java or Kotlin files, open `example/android` in Android studio and find the source files at `<%- project.identifier -%>` under `Android`.
 
 <% } -%>
+
 ### Commit message convention
 
 We follow the [conventional commits specification](https://www.conventionalcommits.org/en) for our commit messages:

packages/create-react-native-library/templates/common/README.md

@@ -18,7 +18,7 @@ import { <%- project.name -%>View } from "<%- project.slug -%>";
 
 <<%- project.name -%>View color="tomato" />
 ```
-<% } else if (project.architecture === 'new' && project.module) { -%>
+<% } else if (project.arch === 'new' && project.module) { -%>
 
 ```js
 import { multiply } from '<%- project.slug -%>';

packages/create-react-native-library/templates/common/example/src/App.tsx

@@ -16,7 +16,7 @@ export default function App() {
     </View>
   );
 }
-<% } else if (project.architecture === 'new' && project.module) { -%>
+<% } else if (project.arch === 'new' && project.module) { -%>
 const result = multiply(3, 7);
 
 export default function App() {

packages/create-react-native-library/templates/kotlin-library-mixed/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Package.kt

@@ -9,7 +9,7 @@ import java.util.HashMap
 
 class <%- project.name -%>Package : TurboReactPackage() {
   override fun getModule(name: String, reactContext: ReactApplicationContext): NativeModule? {
-    return if (name == <%- project.name -%>Module.NAME) {
+    return if (name === <%- project.name -%>Module.NAME) {
       <%- project.name -%>Module(reactContext)
     } else {
       null

packages/create-react-native-library/templates/kotlin-library-new/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Package.kt

@@ -9,7 +9,7 @@ import java.util.HashMap
 
 class <%- project.name -%>Package : TurboReactPackage() {
   override fun getModule(name: String, reactContext: ReactApplicationContext): NativeModule? {
-    return if (name == <%- project.name -%>Module.NAME) {
+    return if (name === <%- project.name -%>Module.NAME) {
       <%- project.name -%>Module(reactContext)
     } else {
       null

packages/create-react-native-library/templates/native-common/android/build.gradle

@@ -80,7 +80,7 @@ android {
     targetCompatibility JavaVersion.VERSION_1_8
   }
 
-<% if (project.architecture == 'new') { -%>
+<% if (project.arch === 'new') { -%>
   sourceSets {
     main {
       if (isNewArchitectureEnabled()) {
@@ -91,7 +91,7 @@ android {
       }
     }
   }
-<% } else if (project.architecture == 'mixed') { -%>
+<% } else if (project.arch === 'mixed') { -%>
   sourceSets {
     main {
       if (isNewArchitectureEnabled()) {

packages/create-react-native-library/templates/native-common/{%- project.identifier %}.podspec

@@ -11,7 +11,7 @@ Pod::Spec.new do |s|
   s.license      = package["license"]
   s.authors      = package["author"]
 
-  s.platforms    = { :ios => <%- project.architecture === "new" ? '"11.0"': '"10.0"' -%> }
+  s.platforms    = { :ios => <%- project.arch === "new" ? '"11.0"': '"10.0"' -%> }
   s.source       = { :git => "<%- repo -%>.git", :tag => "#{s.version}" }
 
 <% if (project.cpp) { -%>
@@ -32,7 +32,7 @@ Pod::Spec.new do |s|
         "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
         "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
     }
-<% if(project.architecture === "new" && project.view) { -%>
+<% if(project.arch === "new" && project.view) { -%>
     s.dependency "React-RCTFabric"
 <% } -%>
     s.dependency "React-Codegen"

packages/create-react-native-library/templates/objc-library/ios/{%- project.name %}.mm

@@ -4,7 +4,7 @@ @implementation <%- project.name -%>
 
 RCT_EXPORT_MODULE()
 
-<% if (project.architecture === 'new') { -%>
+<% if (project.arch === 'new') { -%>
 - (NSNumber *)multiply:(double)a b:(double)b {
 <% if (project.cpp) { -%>
     NSNumber *result = @(<%- project.package_cpp -%>::multiply(a, b));