fix: use cross-spawn for better windows support

closes #12

Author: satya164

package.json

@@ -35,6 +35,7 @@
     "@babel/preset-typescript": "^7.8.3",
     "chalk": "^3.0.0",
     "cosmiconfig": "^6.0.0",
+    "cross-spawn": "^7.0.1",
     "dedent": "^0.7.0",
     "del": "^5.1.0",
     "ejs": "^3.0.1",
@@ -56,6 +57,7 @@
     "@release-it/conventional-changelog": "^1.1.0",
     "@types/babel__core": "^7.1.3",
     "@types/chalk": "^2.2.0",
+    "@types/cross-spawn": "^6.0.1",
     "@types/dedent": "^0.7.0",
     "@types/del": "^4.0.0",
     "@types/ejs": "^3.0.0",

src/create.ts

@@ -1,11 +1,11 @@
-import child_process from 'child_process';
 import path from 'path';
 import fs from 'fs-extra';
 import ejs from 'ejs';
 import dedent from 'dedent';
 import chalk from 'chalk';
 import inquirer from 'inquirer';
 import yargs from 'yargs';
+import spawn from 'cross-spawn';
 import validateNpmPackage from 'validate-npm-package-name';
 import githubUsername from 'github-username';
 import pack from '../package.json';
@@ -29,14 +29,14 @@ export default async function create(argv: yargs.Arguments<any>) {
   let name, email;
 
   try {
-    name = child_process
-      .execSync('git config --get user.name')
-      .toString()
+    name = spawn
+      .sync('git', ['config', '--get', 'user.name'])
+      .stdout.toString()
       .trim();
 
-    email = child_process
-      .execSync('git config --get user.email')
-      .toString()
+    email = spawn
+      .sync('git', ['config', '--get', 'user.email'])
+      .stdout.toString()
       .trim();
   } catch (e) {
     // Ignore error
@@ -178,7 +178,7 @@ export default async function create(argv: yargs.Arguments<any>) {
   await copyDir(TEMPLATE, folder);
 
   try {
-    await child_process.execSync(
+    await spawn.sync(
       'git init && git add . && git commit -m "chore: initial commit"',
       { cwd: folder }
     );

src/targets/typescript.ts

@@ -1,7 +1,7 @@
 import chalk from 'chalk';
 import path from 'path';
-import child_process from 'child_process';
 import fs from 'fs-extra';
+import spawn from 'cross-spawn';
 import del from 'del';
 import JSON5 from 'json5';
 import { platform } from 'os';
@@ -83,22 +83,34 @@ export default async function build({
       (platform() === 'win32' ? '.cmd' : '');
 
     if (!(await fs.pathExists(tsc))) {
-      tsc = child_process
-        .execSync('which tsc')
-        .toString('utf-8')
+      tsc = spawn
+        .sync('which', ['tsc'])
+        .stdout.toString()
         .trim();
+
+      report.warn(
+        `Using a global version of ${chalk.blue(
+          'tsc'
+        )}. Consider adding ${chalk.blue('typescript')} to your ${chalk.blue(
+          'devDependencies'
+        )} instead.`
+      );
     }
 
     if (await fs.pathExists(tsc)) {
-      child_process.execFileSync(tsc, [
-        '--pretty',
-        '--declaration',
-        '--emitDeclarationOnly',
-        '--project',
-        project,
-        '--outDir',
-        output,
-      ]);
+      spawn.sync(
+        tsc,
+        [
+          '--pretty',
+          '--declaration',
+          '--emitDeclarationOnly',
+          '--project',
+          project,
+          '--outDir',
+          output,
+        ],
+        { stdio: 'inherit' }
+      );
 
       await del([
         path.join(output, project.replace(/\.json$/, '.tsbuildinfo')),

yarn.lock

@@ -1254,6 +1254,13 @@
   resolved "https://registry.yarnpkg.com/@types/color-name/-/color-name-1.1.1.tgz#1c1261bbeaa10a8055bbc5d8ab84b7b2afc846a0"
   integrity sha512-rr+OQyAjxze7GgWrSaJwydHStIhHq2lvY3BOC2Mj7KnzI7XK0Uw1TOOdI9lDoajEbSWLiYgoo4f1R51erQfhPQ==
 
+"@types/cross-spawn@^6.0.1":
+  version "6.0.1"
+  resolved "https://registry.yarnpkg.com/@types/cross-spawn/-/cross-spawn-6.0.1.tgz#60fa0c87046347c17d9735e5289e72b804ca9b63"
+  integrity sha512-MtN1pDYdI6D6QFDzy39Q+6c9rl2o/xN7aWGe6oZuzqq5N6+YuwFsWiEAv3dNzvzN9YzU+itpN8lBzFpphQKLAw==
+  dependencies:
+    "@types/node" "*"
+
 "@types/dedent@^0.7.0":
   version "0.7.0"
   resolved "http://localhost:4873/@types%2fdedent/-/dedent-0.7.0.tgz#155f339ca404e6dd90b9ce46a3f78fd69ca9b050"
@@ -2359,6 +2366,15 @@ cross-spawn@^6.0.0, cross-spawn@^6.0.5:
     shebang-command "^1.2.0"
     which "^1.2.9"
 
+cross-spawn@^7.0.1:
+  version "7.0.1"
+  resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-7.0.1.tgz#0ab56286e0f7c24e153d04cc2aa027e43a9a5d14"
+  integrity sha512-u7v4o84SwFpD32Z8IIcPZ6z1/ie24O6RU3RbtL5Y316l3KuHVPx9ItBgWQ6VlfAFnRnTtMUrsQ9MUUTuEZjogg==
+  dependencies:
+    path-key "^3.1.0"
+    shebang-command "^2.0.0"
+    which "^2.0.1"
+
 crypto-random-string@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/crypto-random-string/-/crypto-random-string-1.0.0.tgz#a230f64f568310e1498009940790ec99545bca7e"
@@ -5056,6 +5072,11 @@ path-key@^2.0.0, path-key@^2.0.1:
   resolved "https://registry.yarnpkg.com/path-key/-/path-key-2.0.1.tgz#411cadb574c5a140d3a4b1910d40d80cc9f40b40"
   integrity sha1-QRyttXTFoUDTpLGRDUDYDMn0C0A=
 
+path-key@^3.1.0:
+  version "3.1.1"
+  resolved "https://registry.yarnpkg.com/path-key/-/path-key-3.1.1.tgz#581f6ade658cbba65a0d3380de7753295054f375"
+  integrity sha512-ojmeN0qd+y0jszEtoY48r0Peq5dwMEkIlCOu6Q5f41lfkswXuKtYrhgoTpLnyIcHm24Uhqx+5Tqm2InSwLhE6Q==
+
 path-parse@^1.0.6:
   version "1.0.6"
   resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.6.tgz#d62dbb5679405d72c4737ec58600e9ddcf06d24c"
@@ -5734,11 +5755,23 @@ shebang-command@^1.2.0:
   dependencies:
     shebang-regex "^1.0.0"
 
+shebang-command@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/shebang-command/-/shebang-command-2.0.0.tgz#ccd0af4f8835fbdc265b82461aaf0c36663f34ea"
+  integrity sha512-kHxr2zZpYtdmrN1qDjrrX/Z1rR1kG8Dx+gkpK1G4eXmvXswmcE1hTWBWYUzlraYw1/yZp6YuDY77YtvbN0dmDA==
+  dependencies:
+    shebang-regex "^3.0.0"
+
 shebang-regex@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3"
   integrity sha1-2kL0l0DAtC2yypcoVxyxkMmO/qM=
 
+shebang-regex@^3.0.0:
+  version "3.0.0"
+  resolved "https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-3.0.0.tgz#ae16f1644d873ecad843b0307b143362d4c42172"
+  integrity sha512-7++dFhtcx3353uBaq8DDR4NuxBetBzC7ZQOhmTQInHEd6bSrXdiEyzCvG07Z44UYdLShWUyXt5M/yhz8ekcb1A==
+
 [email protected]:
   version "0.8.3"
   resolved "https://registry.yarnpkg.com/shelljs/-/shelljs-0.8.3.tgz#a7f3319520ebf09ee81275b2368adb286659b097"
@@ -6388,6 +6421,13 @@ which@^1.2.9:
   dependencies:
     isexe "^2.0.0"
 
+which@^2.0.1:
+  version "2.0.2"
+  resolved "https://registry.yarnpkg.com/which/-/which-2.0.2.tgz#7c6a8dd0a636a0327e10b59c9286eee93f3f51b1"
+  integrity sha512-BLI3Tl1TW3Pvl70l3yq3Y64i+awpwXqsGBYWkkqMtnbXgrMD+yj7rhW0kuEDxzJaYXGjEW5ogapKNMEKNMjibA==
+  dependencies:
+    isexe "^2.0.0"
+
 wide-align@^1.1.0:
   version "1.1.3"
   resolved "https://registry.yarnpkg.com/wide-align/-/wide-align-1.1.3.tgz#ae074e6bdc0c14a431e804e624549c633b000457"