feat: upgrade template and repo to Yarn 3

Author: satya164

.github/actions/setup/action.yml

@@ -15,12 +15,13 @@ runs:
       with:
         path: |
           **/node_modules
+          .yarn/install-state.gz
         key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('**/package.json') }}
         restore-keys: |
           ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
           ${{ runner.os }}-yarn-
 
     - name: Install dependencies
       if: steps.yarn-cache.outputs.cache-hit != 'true'
-      run: yarn install --frozen-lockfile
+      run: yarn install --immutable
       shell: bash

.github/workflows/build-templates.yml

@@ -112,7 +112,7 @@ jobs:
             --author-url https://test.test \
             --repo-url https://test.test \
             --type ${{ matrix.type }} \
-            --languages ${{ matrix.language }} \
+            --languages ${{ matrix.language }}
 
       - name: Cache dependencies of library
         id: library-yarn-cache
@@ -129,8 +129,11 @@ jobs:
         if: steps.library-yarn-cache.outputs.cache-hit != 'true'
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn install --cwd example
-          yarn install
+          touch yarn.lock # Without this Yarn will fail due to the parent directory being a Yarn workspace
+          rm -f example/yarn.lock # Workaround for cached yarn.lock from older version
+          yarn install --no-immutable
+        env:
+          POD_INSTALL: 0
 
       - name: Get build target
         working-directory: ${{ env.work_dir }}
@@ -163,8 +166,8 @@ jobs:
         if: env.android_build == 1 || env.ios_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
-          TURBO_CACHE_STATUS_ANDROID=$(node -p "($(yarn --silent turbo run build:android --cache-dir=".turbo/cache" --dry=json)).tasks.find(t => t.task === 'build:android').cache.status")
-          TURBO_CACHE_STATUS_IOS=$(node -p "($(yarn --silent turbo run build:ios --cache-dir=".turbo/cache" --dry=json)).tasks.find(t => t.task === 'build:ios').cache.status")
+          TURBO_CACHE_STATUS_ANDROID=$(node -p "($(yarn turbo run build:android --cache-dir=".turbo" --dry=json)).tasks.find(t => t.task === 'build:android').cache.status")
+          TURBO_CACHE_STATUS_IOS=$(node -p "($(yarn turbo run build:ios --cache-dir=".turbo" --dry=json)).tasks.find(t => t.task === 'build:ios').cache.status")
 
           if [[ $TURBO_CACHE_STATUS_ANDROID == "HIT" ]]; then
             echo "turbo_cache_hit_android=1" >> $GITHUB_ENV
@@ -227,7 +230,7 @@ jobs:
         if: env.android_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn turbo run build:android --cache-dir=".turbo/cache"
+          yarn turbo run build:android --cache-dir=".turbo"
 
       - name: Cache cocoapods
         if: env.ios_build == 1 && env.turbo_cache_hit_ios != 1
@@ -246,12 +249,12 @@ jobs:
         if: env.ios_build == 1 && env.turbo_cache_hit_ios != 1 && steps.library-cocoapods-cache.outputs.cache-hit != 'true'
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn example pods
+          yarn pod-install example/ios
         env:
           NO_FLIPPER: 1
 
       - name: Build example (iOS)
         if: env.ios_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn turbo run build:ios --cache-dir=".turbo/cache"
+          yarn turbo run build:ios --cache-dir=".turbo"

.gitignore

@@ -41,6 +41,14 @@ build/Release
 node_modules/
 jspm_packages/
 
+# Yarn
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
+
 # Typescript v1 declaration files
 typings/
 

.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

@@ -0,0 +1,9 @@
+nodeLinker: node-modules
+
+plugins:
+  - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
+    spec: "@yarnpkg/plugin-workspace-tools"
+  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
+    spec: "@yarnpkg/plugin-interactive-tools"
+
+yarnPath: .yarn/releases/yarn-3.6.1.cjs

.yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs

@@ -9,10 +9,10 @@
     "type": "git",
     "url": "git+https://github.com/react-navigation/react-navigation.git"
   },
+  "packageManager": "[email protected]",
   "engines": {
     "node": ">= 18.0.0"
   },
-  "packageManager": "^[email protected]",
   "scripts": {
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
     "typecheck": "tsc --noEmit",

.yarn/releases/yarn-3.6.1.cjs

@@ -24,9 +24,7 @@
   },
   "homepage": "https://github.com/callstack/react-native-builder-bob/blob/main/README.md",
   "main": "lib/index.js",
-  "bin": {
-    "create-react-native-library": "bin/create-react-native-library"
-  },
+  "bin": "bin/create-react-native-library",
   "files": [
     "lib",
     "templates"

.yarnrc.yml

@@ -13,7 +13,10 @@ import { spawn } from './utils/spawn';
 
 const FALLBACK_BOB_VERSION = '0.20.0';
 
-const BINARIES = /(gradlew|\.(jar|keystore|png|jpg|gif))$/;
+const BINARIES = [
+  /(gradlew|\.(jar|keystore|png|jpg|gif))$/,
+  /\$\.yarn(?![a-z])/,
+];
 
 const COMMON_FILES = path.resolve(__dirname, '../templates/common');
 const JS_FILES = path.resolve(__dirname, '../templates/js-library');
@@ -573,7 +576,7 @@ async function create(argv: yargs.Arguments<any>) {
 
       if (stats.isDirectory()) {
         await copyDir(file, target);
-      } else if (!file.match(BINARIES)) {
+      } else if (!BINARIES.some((r) => r.test(file))) {
         const content = await fs.readFile(file, 'utf8');
 
         await fs.writeFile(target, ejs.render(content, options));
@@ -604,6 +607,7 @@ async function create(argv: yargs.Arguments<any>) {
   await generateExampleApp({
     type: example,
     dest: folder,
+    slug: options.project.slug,
     projectName: options.project.name,
     arch,
     reactNativeVersion,

package.json

@@ -50,12 +50,14 @@ const PACKAGES_TO_ADD_WEB_DEV = {
 export default async function generateExampleApp({
   type,
   dest,
+  slug,
   projectName,
   arch,
   reactNativeVersion = 'latest',
 }: {
   type: 'expo' | 'native';
   dest: string;
+  slug: string;
   projectName: string;
   arch: 'new' | 'mixed' | 'legacy';
   reactNativeVersion?: string;
@@ -93,6 +95,8 @@ export default async function generateExampleApp({
     await fs.readFile(path.join(directory, 'package.json'), 'utf8')
   );
 
+  pkg.name = `${slug}-example`;
+
   // Remove Jest config for now
   delete pkg.jest;
 
@@ -101,8 +105,14 @@ export default async function generateExampleApp({
   delete scripts.test;
   delete scripts.lint;
 
+  const SCRIPTS_TO_ADD = {
+    'build:android':
+      'cd android && ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a',
+    'build:ios': `cd ios && xcodebuild -workspace ${projectName}Example.xcworkspace -scheme ${projectName}Example -configuration Debug -sdk iphonesimulator CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ GCC_OPTIMIZATION_LEVEL=0 GCC_PRECOMPILE_PREFIX_HEADER=YES ASSETCATALOG_COMPILER_OPTIMIZATION=time DEBUG_INFORMATION_FORMAT=dwarf COMPILER_INDEX_STORE_ENABLE=NO`,
+  };
+
   if (type === 'native') {
-    scripts.pods = 'pod-install --quiet';
+    Object.assign(scripts, SCRIPTS_TO_ADD);
   }
 
   PACKAGES_TO_REMOVE.forEach((name) => {

packages/create-react-native-library/package.json

@@ -15,14 +15,13 @@ runs:
       with:
         path: |
           **/node_modules
+          .yarn/install-state.gz
         key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('**/package.json') }}
         restore-keys: |
           ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
           ${{ runner.os }}-yarn-
 
     - name: Install dependencies
       if: steps.yarn-cache.outputs.cache-hit != 'true'
-      run: |
-        yarn install --cwd example --frozen-lockfile
-        yarn install --frozen-lockfile
+      run: yarn install --immutable
       shell: bash

packages/create-react-native-library/src/index.ts

@@ -69,7 +69,7 @@ jobs:
 
       - name: Check turborepo cache for Android
         run: |
-          TURBO_CACHE_STATUS=$(node -p "($(yarn --silent turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:android').cache.status")
+          TURBO_CACHE_STATUS=$(node -p "($(yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:android').cache.status")
 
           if [[ $TURBO_CACHE_STATUS == "HIT" ]]; then
             echo "turbo_cache_hit=1" >> $GITHUB_ENV
@@ -123,7 +123,7 @@ jobs:
 
       - name: Check turborepo cache for iOS
         run: |
-          TURBO_CACHE_STATUS=$(node -p "($(yarn --silent turbo run build:ios --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:ios').cache.status")
+          TURBO_CACHE_STATUS=$(node -p "($(yarn turbo run build:ios --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:ios').cache.status")
 
           if [[ $TURBO_CACHE_STATUS == "HIT" ]]; then
             echo "turbo_cache_hit=1" >> $GITHUB_ENV
@@ -143,7 +143,7 @@ jobs:
       - name: Install cocoapods
         if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true'
         run: |
-          yarn example pods
+          yarn pod-install example/ios
         env:
           NO_FLIPPER: 1
 

packages/create-react-native-library/src/utils/generateExampleApp.ts

@@ -60,6 +60,14 @@ buck-out/
 android/app/libs
 android/keystores/debug.keystore
 
+# Yarn
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
+
 # Expo
 .expo/