refactor: simplify gradle configuration

Author: satya164

.github/workflows/build-templates.yml

@@ -201,10 +201,6 @@ jobs:
         run: |
           yarn turbo run build:android --cache-dir=".turbo/cache"
 
-      - name: Cache iOS build
-        if: env.ios_build == 1
-        uses: mikehardy/buildcache-action@v1
-
       - name: Cache cocoapods
         if: env.ios_build == 1
         id: library-cocoapods-cache
@@ -225,17 +221,7 @@ jobs:
           yarn example pods
         env:
           NO_FLIPPER: 1
-
-      - name: Cache iOS build artifacts
-        if: env.ios_build == 1
-        uses: actions/cache@v3
-        with:
-          path: |
-            ~/Library/Developer/Xcode/DerivedData
-          key: ${{ runner.os }}-library-xcode-derived-data-${{ hashFiles(format('{0}/**/Podfile', env.work_dir)) }}-${{ hashFiles(format('{0}/**/yarn.lock', env.work_dir)) }}
-          restore-keys: |
-            ${{ runner.os }}-library-xcode-derived-data-${{ hashFiles(format('{0}/**/Podfile', env.work_dir)) }}-
-            ${{ runner.os }}-library-xcode-derived-data-
+          CI: 0 # Hermes is built from source when CI=1
 
       - name: Build example (iOS)
         if: env.ios_build == 1

packages/create-react-native-library/templates/native-common/android/build.gradle

@@ -22,39 +22,6 @@ def isNewArchitectureEnabled() {
   return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true"
 }
 
-def resolveReactNativeDirectory() {
-  def reactNativeLocation = rootProject.hasProperty("reactNativeDir") ? rootProject.getProperty("reactNativeDir") : null
-
-  if (reactNativeLocation != null) {
-    return file(reactNativeLocation)
-  }
-
-  try {
-    // Resolve React Native location with Node
-    // This will make sure that we get installation location correctly in monorepos
-    def reactNativePackageJsonPathStdout = new ByteArrayOutputStream()
-
-    exec {
-      commandLine("node", "-p", "require.resolve('react-native/package.json')")
-      ignoreExitValue true
-      standardOutput = reactNativePackageJsonPathStdout
-    }
-
-    def reactNativeFromProjectNodeModules = file(reactNativePackageJsonPathStdout.toString().trim()).getParentFile();
-
-    if (reactNativeFromProjectNodeModules.exists()) {
-      return reactNativeFromProjectNodeModules
-    }
-  } catch (e) {
-    // Ignore
-  }
-
-  throw new Exception(
-    "${project.name}: Failed to resolve 'react-native' in the project. " +
-    "If you have a non-standard project structure, you can specify 'reactNativeDir' with the path to 'react-native' in your 'gradle.properties' file."
-  )
-}
-
 apply plugin: "com.android.library"
 <% if (project.kotlin) { -%>
 apply plugin: "kotlin-android"
@@ -72,13 +39,6 @@ def getExtOrIntegerDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : (project.properties["<%- project.name -%>_" + name]).toInteger()
 }
 
-def reactNativeRootDir = resolveReactNativeDirectory()
-def reactProperties = new Properties()
-file("$reactNativeRootDir/ReactAndroid/gradle.properties").withInputStream { reactProperties.load(it) }
-
-def reactNativeVersion = reactProperties.getProperty("VERSION_NAME")
-def (reactNativeMajorVersion, reactNativeMinorVersion) = reactNativeVersion.split("\\.").collect { it.isInteger() ? it.toInteger() : it }
-
 android {
 <% if (project.cpp) { -%>
   ndkVersion getExtOrDefault("ndkVersion")
@@ -151,33 +111,17 @@ android {
 repositories {
   mavenCentral()
   google()
-
-  if (reactNativeMajorVersion == 0 && reactNativeMinorVersion < 71) {
-    def androidSourcesDir = file("$reactNativeRootDir/android")
-    def androidSourcesName = "React Native sources"
-
-    if (androidSourcesDir.exists()) {
-      maven {
-        url androidSourcesDir.toString()
-        name androidSourcesName
-      }
-    }
-  }
 }
 
 <% if (project.kotlin) { -%>
 def kotlin_version = getExtOrDefault("kotlinVersion")
 <% } -%>
 
 dependencies {
-  if (reactNativeMajorVersion == 0 && reactNativeMinorVersion < 71) {
-    //noinspection GradleDynamicVersion
-    implementation "com.facebook.react:react-native:+"
-    // From node_modules
-  } else {
-    implementation "com.facebook.react:react-android"
-  }
-
+  // For < 0.71, this will be from the local maven repo
+  // For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin
+  //noinspection GradleDynamicVersion
+  implementation "com.facebook.react:react-native:+"
 <% if (project.kotlin) { -%>
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
 <% } -%>