fix: add support for react native 0.71

Author: satya164

.github/workflows/build-templates.yml

@@ -91,23 +91,9 @@ jobs:
         run: |
           yarn workspace create-react-native-library prepare
 
-      - name: Configure environment
+      - name: Get working directory
         run: |
-          echo "work_dir=tmp-${{ matrix.type }}-${{ matrix.language }}" >> $GITHUB_ENV
-
-          # Build Android for only some matrices to skip redundant builds
-          if [[ ${{ matrix.os }} == ubuntu ]]; then
-            if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
-              echo "build_android=1" >> $GITHUB_ENV
-            fi
-          fi
-
-          # Build iOS for only some matrices to skip redundant builds
-          if [[ ${{ matrix.os }} == macos ]]; then
-            if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
-              echo "build_ios=1" >> $GITHUB_ENV
-            fi
-          fi
+          echo "work_dir=${{ matrix.os }}-${{ matrix.type }}-${{ matrix.language }}" >> $GITHUB_ENV
 
       - name: Create library
         run: |
@@ -120,6 +106,7 @@ jobs:
             --repo-url https://test.test \
             --type ${{ matrix.type }} \
             --languages ${{ matrix.language }} \
+            --react-native-version 0.71.0-rc.3 \
             --turborepo
 
       - name: Cache dependencies of library
@@ -149,68 +136,71 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-library-turborepo-${{ matrix.type }}-${{ matrix.language }}-
 
+      - name: Get build target
+        working-directory: ${{ env.work_dir }}
+        run: |
+          # Build Android for only some matrices to skip redundant builds
+          if [[ ${{ matrix.os }} == ubuntu ]]; then
+            if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
+              echo "android_build=1" >> $GITHUB_ENV
+            fi
+          fi
+
+          # Build iOS for only some matrices to skip redundant builds
+          if [[ ${{ matrix.os }} == macos ]]; then
+            if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
+              echo "ios_build=1" >> $GITHUB_ENV
+            fi
+          fi
+
       - name: Lint library
-        if: matrix.os == 'ubuntu'
         working-directory: ${{ env.work_dir }}
         run: |
           yarn lint
 
       - name: Typecheck library
-        if: matrix.os == 'ubuntu'
         working-directory: ${{ env.work_dir }}
         run: |
-          yarn typescript
+          yarn typecheck
 
       - name: Test library
-        if: matrix.os == 'ubuntu'
         working-directory: ${{ env.work_dir }}
         run: |
           yarn test
 
       - name: Install JDK
-        if: env.build_android == 1
+        if: env.android_build == 1
         uses: actions/setup-java@v3
         with:
           distribution: 'zulu'
           java-version: '11'
 
-      - name: Install NDK
-        if: env.build_android == 1
-        uses: nttld/setup-ndk@v1
-        with:
-          ndk-version: r21d
-          local-cache: true
-
-      - name: Finalize Android NDK & SDK
-        if: env.build_android == 1
+      - name: Finalize Android SDK
+        if: env.android_build == 1
         run: |
-          echo "ANDROID_NDK=$ANDROID_HOME/ndk-bundle" >> $GITHUB_ENV
           /bin/bash -c "yes | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --licenses > /dev/null"
 
       - name: Cache Gradle
-        if: env.build_android == 1
+        if: env.android_build == 1
         uses: actions/cache@v3
         with:
           path: |
             ~/.gradle/wrapper
             ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles(format('{0}/example/android/gradle/wrapper/gradle-wrapper.properties', env.work_dir)) }}
 
-      - name: Cache android libraries
-        if: env.build_android == 1
-        uses: actions/cache@v3
-        with:
-          path: ${{ env.work_dir }}/example/android/app/build/react-ndk
-          key: ${{ runner.os }}-react-ndk-${{ hashFiles(format('{0}/example/node_modules/react-native/package.json', env.work_dir)) }}
-
       - name: Build example (Android)
-        if: env.build_android == 1
+        if: env.android_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
           yarn turbo run build:android --cache-dir=".turbo/cache"
 
+      - name: Cache iOS build
+        if: env.ios_build == 1
+        uses: mikehardy/buildcache-action@v1
+
       - name: Cache cocoapods
-        if: env.build_ios == 1
+        if: env.ios_build == 1
         id: library-cocoapods-cache
         uses: actions/cache@v3
         with:
@@ -222,15 +212,15 @@ jobs:
             ${{ runner.os }}-library-cocoapods-${{ env.work_dir }}-
 
       - name: Install cocoapods
-        if: steps.library-cocoapods-cache.outputs.cache-hit != 'true' && env.build_ios == 1
+        if: steps.library-cocoapods-cache.outputs.cache-hit != 'true' && env.ios_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
           yarn example pods
         env:
           NO_FLIPPER: 1
 
       - name: Cache iOS build artifacts
-        if: env.build_ios == 1
+        if: env.ios_build == 1
         uses: actions/cache@v3
         with:
           path: |
@@ -240,7 +230,7 @@ jobs:
             ${{ runner.os }}-library-xcode-derived-data-${{ env.work_dir }}-
 
       - name: Build example (iOS)
-        if: env.build_ios == 1
+        if: env.ios_build == 1
         working-directory: ${{ env.work_dir }}
         run: |
           yarn turbo run build:ios --cache-dir=".turbo/cache"

.github/workflows/check-project.yml

@@ -16,7 +16,7 @@ jobs:
         run: yarn lint
 
       - name: Typecheck
-        run: yarn typescript
+        run: yarn typecheck
 
       - name: Build packages
         run: yarn lerna run prepare

README.md

@@ -355,7 +355,7 @@ To test the CLI locally, you can point to the `bin/bob` executable:
 Before sending a pull request, make sure your code passes TypeScript and ESLint. Run the following to verify:
 
 ```sh
-yarn typescript
+yarn typecheck
 yarn lint
 ```
 

package.json

@@ -15,8 +15,8 @@
   "packageManager": "^[email protected]",
   "scripts": {
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
-    "typescript": "tsc --noEmit",
-    "watch": "concurrently 'yarn typescript --watch' 'lerna run --parallel prepare -- --watch'"
+    "typecheck": "tsc --noEmit",
+    "watch": "concurrently 'yarn typecheck --watch' 'lerna run --parallel prepare -- --watch'"
   },
   "devDependencies": {
     "@arkweid/lefthook": "^0.7.7",

packages/create-react-native-library/src/utils/generateExampleApp.ts

@@ -11,15 +11,25 @@ const FILES_TO_DELETE = [
   '.gitignore',
   '.prettierrc.js',
   'App.js',
+  'App.tsx',
   'index.js',
+  'tsconfig.json',
 ];
 
 const PACKAGES_TO_REMOVE = [
   '@react-native-community/eslint-config',
+  '@tsconfig/react-native',
+  '@types/jest',
+  '@types/react',
+  '@types/react-test-renderer',
+  '@typescript-eslint/eslint-plugin',
+  '@typescript-eslint/parser',
   'babel-jest',
   'eslint',
   'jest',
+  'prettier',
   'react-test-renderer',
+  'typescript',
 ];
 
 const PACKAGES_TO_ADD = {

packages/create-react-native-library/templates/common/$.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
         run: yarn lint
 
       - name: Typecheck files
-        run: yarn typescript
+        run: yarn typecheck
 
   test:
     runs-on: ubuntu-latest

packages/create-react-native-library/templates/common/$package.json

@@ -28,14 +28,14 @@
   ],
   "scripts": {
     "test": "jest",
-    "typescript": "tsc --noEmit",
+    "typecheck": "tsc --noEmit",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
     "prepare": "bob build",
     "release": "release-it",
     "example": "yarn --cwd example",
 <% if (example === 'native' && turborepo) { -%>
     "build:android": "cd example/android && ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a",
-    "build:ios": "cd example/ios && xcodebuild -workspace <%- project.name %>Example.xcworkspace -configuration Debug -scheme <%- project.name %>Example -destination 'generic/platform=iOS' CODE_SIGN_IDENTITY='' CODE_SIGNING_REQUIRED=NO",
+    "build:ios": "cd example/ios && xcodebuild -workspace <%- project.name %>Example.xcworkspace -scheme <%- project.name %>Example -configuration Debug -sdk iphonesimulator CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ ASSETCATALOG_COMPILER_OPTIMIZATION=time DEBUG_INFORMATION_FORMAT=dwarf GCC_OPTIMIZATION_LEVEL=fast GCC_PRECOMPILE_PREFIX_HEADER=YES GCC_UNROLL_LOOPS=YES COMPILER_INDEX_STORE_ENABLE=NO",
 <% } -%>
 <% if (example === 'native') { -%>
     "bootstrap": "yarn example && yarn install && yarn example pods",

packages/create-react-native-library/templates/common/CONTRIBUTING.md

@@ -78,7 +78,7 @@ yarn example web
 Make sure your code passes TypeScript and ESLint. Run the following to verify:
 
 ```sh
-yarn typescript
+yarn typecheck
 yarn lint
 ```
 
@@ -137,7 +137,7 @@ yarn release
 The `package.json` file contains various scripts for common tasks:
 
 - `yarn bootstrap`: setup project by installing all dependencies and pods.
-- `yarn typescript`: type-check files with TypeScript.
+- `yarn typecheck`: type-check files with TypeScript.
 - `yarn lint`: lint files with ESLint.
 - `yarn test`: run unit tests with Jest.
 - `yarn example start`: start the Metro server for the example app.