Skip to content

fix: android build.gradle typo #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

fix: android build.gradle typo #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40413d2
fix: android build.gradle typo
Sunbreak Feb 27, 2023
2cee114
Merge branch 'main' into fix-template-typo
satya164 Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/create-react-native-library/templates/native-common/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def registrationCompat = {
? file("$projectDir/../node_modules/react-native/package.json") // developer mode, to run example app
: file("$projectDir/../../react-native/package.json")
def reactNativeVersion = new JsonSlurper().parseText(reactNativeManifest.text).version as String
// Fabric was introduced at [email protected], full CMake support were introduced at react-native@0.71
// Fabric was introduced at [email protected], full CMake support were introduced at react-native@0.70
// Use Android.mk for compatibility with [email protected]/0.69
reactNativeVersion.matches('(0.68.*|0.69.*)')
}()
Expand Down Expand Up @@ -186,7 +186,7 @@ dependencies {
if (isNewArchitectureEnabled()) {
react {
jsRootDir = file("../src/")
<% if (project.view && (project.arch === "new" || project.arch === "mixed")) { %>
<% if (project.view && (project.arch === "new" || project.arch === "mixed")) { -%>
libraryName = codegenViewLibraryName
<% } else { -%>
libraryName = "<%- project.view ? project.name + 'View' : project.name -%>"
Expand Down