Skip to content

feat: bump node version to 18 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat: bump node version to 18 #418

merged 2 commits into from
Jul 12, 2023

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Jul 7, 2023

Summary

This bumps the node version of the project to v18.12.0(18 LtS)

Why?

  1. Node.js 16 LTS is coming to end-of-life later this year. Source
  2. You are not able to install the dependencies of react native example app anymore. It raises the following error:
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.18.1"

Test plan

As this doesn't add any feature, we need to make sure the core functionality is not broken and all the CI checks pass.

@satya164 satya164 changed the title chore: bump node version to 18lts both for monorepo and templates feat: bump node version to 18 Jul 12, 2023
@satya164 satya164 enabled auto-merge (squash) July 12, 2023 12:33
@satya164 satya164 merged commit 7fa4a76 into main Jul 12, 2023
@satya164 satya164 deleted the @atlj/bump-node-version branch July 12, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlj @satya164