Skip to content

Commit 245d1d1

Browse files
committed
fix: for date picker, remove invalid aria role and add aria-description
1 parent 23ef956 commit 245d1d1

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/components/CvDatePicker/CvDatePicker.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
ref="date"
4141
type="text"
4242
data-date-picker-input
43-
role="datepicker"
43+
data-testid="datepicker"
44+
:aria-description="placeholder"
4445
:data-invalid="isInvalid || null"
4546
:disabled="disabled || null"
4647
:data-date-picker-input-from="`${getKind === 'range'}`"
@@ -85,7 +86,8 @@
8586
ref="todate"
8687
type="text"
8788
data-date-picker-input
88-
role="todatepicker"
89+
data-testid="todatepicker"
90+
:aria-description="placeholder"
8991
:data-date-picker-input-to="`${kind === 'range'}`"
9092
:data-invalid="isInvalid || null"
9193
:disabled="disabled || null"

src/components/CvDatePicker/__tests__/CvDatePicker.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('CvDatePicker', () => {
1717
},
1818
});
1919

20-
const datepicker = await result.findByRole('datepicker');
20+
const datepicker = await result.findByTestId('datepicker');
2121

2222
const user = userEvent.setup();
2323

@@ -56,7 +56,7 @@ describe('CvDatePicker', () => {
5656
},
5757
});
5858

59-
const datepicker = await result.findByRole('datepicker');
59+
const datepicker = await result.findByTestId('datepicker');
6060

6161
const user = userEvent.setup();
6262

@@ -118,8 +118,8 @@ describe('CvDatePicker', () => {
118118
},
119119
});
120120

121-
const datepicker = await result.findByRole('datepicker');
122-
const todatepicker = await result.findByRole('todatepicker');
121+
const datepicker = await result.findByTestId('datepicker');
122+
const todatepicker = await result.findByTestId('todatepicker');
123123

124124
const user = userEvent.setup();
125125

0 commit comments

Comments
 (0)