Pkt: handle final LF and capabilities string

Remove the final LF in each pkt line so ref names are stored correctly
and split out the capabilities string explicitly, as C# doesn't stop
at the first NUL.

References libgit2#210

Author: carlosmn

LibGit2Sharp/Pkt.cs

@@ -23,6 +23,7 @@ public class PktRef : Pkt
     {
         public readonly ObjectId Id;
         public readonly string Name;
+        public readonly string CapString;
 
         public PktRef(BinaryReader reader, int len)
         {
@@ -32,7 +33,25 @@ public PktRef(BinaryReader reader, int len)
             ObjectId.TryParse(hash, out Id);
             reader.ReadByte(); /* Skip the SP */
             len -= 1; /* The SP */
-            Name = Encoding.UTF8.GetString(reader.ReadBytes(len));
+
+            /* Each line SHOULD end with LF, but unfortunately we can't rely on it being there */
+            var tmp = Encoding.UTF8.GetString(reader.ReadBytes(len));
+            if (tmp.EndsWith("\n"))
+                tmp = tmp.Remove(tmp.Length - 1);
+
+            /*
+             * The server's capabilities are sent as "HEAD" NUL "cap1 cap2". In
+             * C it works just fine, but C# knows that the string doesn't stop
+             * at the first NUL, so we need to split it out explicitly.
+             */
+            var nul = tmp.IndexOf('\0');
+            if (nul == -1) {
+                Name = tmp;
+            } else {
+                var parts = tmp.Split('\0');
+                Name = parts[0];
+                CapString = parts[1];
+            }
         }
     }