TODOs added

Author: peterbanda

pinecone-client/src/main/scala/io/cequence/pineconescala/service/EndPoint.scala

@@ -19,6 +19,7 @@ object EndPoint {
   case object indexes extends EndPoint
 }
 
+// TODO: rename to Param
 sealed abstract class Tag(value: String = "") extends NamedEnumValue(value)
 
 object Tag {

pinecone-client/src/main/scala/io/cequence/pineconescala/service/PineconeIndexServiceImpl.scala

@@ -387,4 +387,13 @@ object PineconeIndexServiceFactory extends PineconeServiceFactoryHelper {
         Right(new ServerlessIndexServiceImpl(apiKey, timeouts))
     }
 
+  implicit class FactoryImplicits(
+    either: Either[PineconePodBasedIndexService, PineconeServerlessIndexService]
+  ) {
+    def asOne: PineconeIndexService[_] =
+      either match {
+        case Left(service)  => service
+        case Right(service) => service
+      }
+  }
 }

pinecone-client/src/main/scala/io/cequence/pineconescala/service/PineconeInferenceServiceImpl.scala

@@ -4,10 +4,8 @@ import akka.stream.Materializer
 import com.typesafe.config.Config
 import io.cequence.pineconescala.domain.response.GenerateEmbeddingsResponse
 import io.cequence.pineconescala.domain.settings.{GenerateEmbeddingsSettings, IndexSettings}
-import io.cequence.wsclient.JsonUtil.{JsonOps, toJson}
 import io.cequence.wsclient.ResponseImplicits._
 import io.cequence.wsclient.service.ws.{Timeouts, WSRequestHelper}
-import play.api.libs.json.{JsArray, JsNull, JsObject, JsValue, Json}
 import io.cequence.pineconescala.JsonFormats._
 import io.cequence.pineconescala.PineconeScalaClientException
 import io.cequence.wsclient.domain.WsRequestContext

pinecone-core/src/main/scala/io/cequence/pineconescala/service/PineconeInferenceService.scala

@@ -17,9 +17,9 @@ trait PineconeInferenceService extends CloseableService with PineconeServiceCons
    * @return
    *   list of embeddings inside an envelope
    */
+  // TODO: rename to embedData to be consistent with the API
   def createEmbeddings(
     inputs: Seq[String],
     settings: GenerateEmbeddingsSettings = DefaultSettings.GenerateEmbeddings
   ): Future[GenerateEmbeddingsResponse]
-
 }