Fix PHP 7.1 compat (symfony#86)

dunglas · web-flow · commit 029b43116e56 · 2018-09-23T20:57:43.000+02:00
* Fix PHP 7.1 compat

* Fix PHPDoc. Add test.
diff --git a/src/Client.php b/src/Client.php
@@ -13,6 +13,9 @@
 
 namespace Symfony\Component\Panther;
 
+use Facebook\WebDriver\Exception\NoSuchElementException;
+use Facebook\WebDriver\Exception\TimeOutException;
+use Facebook\WebDriver\Remote\RemoteWebElement;
 use Facebook\WebDriver\WebDriver;
 use Facebook\WebDriver\WebDriverBy;
 use Facebook\WebDriver\WebDriverCapabilities;
@@ -226,7 +229,13 @@ public function getCookieJar()
         return new CookieJar($this->webDriver);
     }
 
-    public function waitFor(string $cssSelector, int $timeoutInSecond = 30, int $intervalInMillisecond = 250): object
+    /**
+     * @throws NoSuchElementException
+     * @throws TimeOutException
+     *
+     * @return RemoteWebElement
+     */
+    public function waitFor(string $cssSelector, int $timeoutInSecond = 30, int $intervalInMillisecond = 250)
     {
         return $this->wait($timeoutInSecond, $intervalInMillisecond)->until(
             WebDriverExpectedCondition::visibilityOfElementLocated(WebDriverBy::cssSelector($cssSelector))
diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -13,6 +13,7 @@
 
 namespace Symfony\Component\Panther\Tests;
 
+use Facebook\WebDriver\Remote\RemoteWebElement;
 use Facebook\WebDriver\WebDriver;
 use Symfony\Component\BrowserKit\Client as BrowserKitClient;
 use Symfony\Component\BrowserKit\Cookie;
@@ -34,6 +35,15 @@ public function testCreateClient()
         $this->assertInstanceOf(WebDriver::class, $client);
     }
 
+    public function testWaitFor()
+    {
+        $client = self::createPantherClient();
+        $crawler = $client->request('GET', '/waitfor.html');
+        $c = $client->waitFor('#hello');
+        $this->assertInstanceOf(RemoteWebElement::class, $c);
+        $this->assertSame('Hello', $crawler->filter('#hello')->text());
+    }
+
     /**
      * @dataProvider clientFactoryProvider
      */
diff --git a/tests/fixtures/waitfor.html b/tests/fixtures/waitfor.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>WaitFor</title>
+</head>
+<body>
+<div id="root"></div>
+
+<template id="t-hello">
+    <p id="hello">Hello</p>
+</template>
+
+<script>
+    window.setTimeout(function () {
+        document.getElementById('root').appendChild(
+            document.importNode(document.getElementById('t-hello').content, true)
+        );
+    }, 1000);
+</script>
+</body>
+</html>
