Merge branch '5.4' into 6.4

* 5.4:
  [Intl] Update ICU data from 74.1 to 75.1
  use DeprecatedCallableInfo for Twig callables if possible
  [Filesystem] Add a warning about `chown()` and `chgrp()` on Windows
  [String] Update wcswidth data with Unicode 16
  Work around parse_url() bug
  [Ldap] Clean `ldap_connect()` call in `LdapTestCase`
  [HttpFoundation] Update links for X-Accel-Redirect and fail properly when X-Accel-Mapping is missing

Author: xabbuh

src/Symfony/Bridge/Twig/Tests/Command/LintCommandTest.php

@@ -18,6 +18,7 @@
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Tester\CommandCompletionTester;
 use Symfony\Component\Console\Tester\CommandTester;
+use Twig\DeprecatedCallableInfo;
 use Twig\Environment;
 use Twig\Loader\FilesystemLoader;
 use Twig\TwigFilter;
@@ -159,7 +160,12 @@ private function createCommandTester(): CommandTester
     private function createCommand(): Command
     {
         $environment = new Environment(new FilesystemLoader(\dirname(__DIR__).'/Fixtures/templates/'));
-        $environment->addFilter(new TwigFilter('deprecated_filter', fn ($v) => $v, ['deprecated' => true]));
+        if (class_exists(DeprecatedCallableInfo::class)) {
+            $options = ['deprecation_info' => new DeprecatedCallableInfo('foo/bar', '1.1')];
+        } else {
+            $options = ['deprecated' => true];
+        }
+        $environment->addFilter(new TwigFilter('deprecated_filter', fn ($v) => $v, $options));
 
         $command = new LintCommand($environment);
 

src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php

@@ -119,13 +119,17 @@ public function urlRedirectAction(Request $request, string $path, bool $permanen
             $statusCode = $permanent ? 301 : 302;
         }
 
+        $scheme ??= $request->getScheme();
+
+        if (str_starts_with($path, '//')) {
+            $path = $scheme.':'.$path;
+        }
+
         // redirect if the path is a full URL
         if (parse_url($path, \PHP_URL_SCHEME)) {
             return new RedirectResponse($path, $statusCode);
         }
 
-        $scheme ??= $request->getScheme();
-
         if ($qs = $request->server->get('QUERY_STRING') ?: $request->getQueryString()) {
             if (!str_contains($path, '?')) {
                 $qs = '?'.$qs;

src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php

@@ -183,6 +183,20 @@ public function testFullURLWithMethodKeep()
         $this->assertEquals(307, $returnResponse->getStatusCode());
     }
 
+    public function testProtocolRelative()
+    {
+        $request = new Request();
+        $controller = new RedirectController();
+
+        $returnResponse = $controller->urlRedirectAction($request, '//foo.bar/');
+        $this->assertRedirectUrl($returnResponse, 'http://foo.bar/');
+        $this->assertSame(302, $returnResponse->getStatusCode());
+
+        $returnResponse = $controller->urlRedirectAction($request, '//foo.bar/', false, 'https');
+        $this->assertRedirectUrl($returnResponse, 'https://foo.bar/');
+        $this->assertSame(302, $returnResponse->getStatusCode());
+    }
+
     public function testUrlRedirectDefaultPorts()
     {
         $host = 'www.example.com';

src/Symfony/Component/DomCrawler/Tests/UriResolverTest.php

@@ -86,6 +86,7 @@ public static function provideResolverTests()
             ['foo', 'http://localhost#bar', 'http://localhost/foo'],
 
             ['http://', 'http://localhost', 'http://'],
+            ['/foo:123', 'http://localhost', 'http://localhost/foo:123'],
         ];
     }
 }

src/Symfony/Component/DomCrawler/UriResolver.php

@@ -32,8 +32,12 @@ public static function resolve(string $uri, ?string $baseUri): string
     {
         $uri = trim($uri);
 
+        if (false === ($scheme = parse_url($uri, \PHP_URL_SCHEME)) && '/' === ($uri[0] ?? '')) {
+            $scheme = parse_url($uri.'#', \PHP_URL_SCHEME);
+        }
+
         // absolute URL?
-        if (null !== parse_url($uri, \PHP_URL_SCHEME)) {
+        if (null !== $scheme) {
             return $uri;
         }
 

src/Symfony/Component/Filesystem/Filesystem.php

@@ -233,6 +233,9 @@ public function chmod(string|iterable $files, int $mode, int $umask = 0000, bool
     /**
      * Change the owner of an array of files or directories.
      *
+     * This method always throws on Windows, as the underlying PHP function is not supported.
+     * @see https://www.php.net/chown
+     *
      * @param string|int $user      A user name or number
      * @param bool       $recursive Whether change the owner recursively or not
      *
@@ -261,6 +264,9 @@ public function chown(string|iterable $files, string|int $user, bool $recursive
     /**
      * Change the group of an array of files or directories.
      *
+     * This method always throws on Windows, as the underlying PHP function is not supported.
+     * @see https://www.php.net/chgrp
+     *
      * @param string|int $group     A group name or number
      * @param bool       $recursive Whether change the group recursively or not
      *

src/Symfony/Component/HttpClient/HttpClientTrait.php

@@ -627,7 +627,10 @@ private static function resolveUrl(array $url, ?array $base, array $queryDefault
     private static function parseUrl(string $url, array $query = [], array $allowedSchemes = ['http' => 80, 'https' => 443]): array
     {
         if (false === $parts = parse_url($url)) {
-            throw new InvalidArgumentException(sprintf('Malformed URL "%s".', $url));
+            if ('/' !== ($url[0] ?? '') || false === $parts = parse_url($url.'#')) {
+                throw new InvalidArgumentException(sprintf('Malformed URL "%s".', $url));
+            }
+            unset($parts['fragment']);
         }
 
         if ($query) {

src/Symfony/Component/HttpClient/NativeHttpClient.php

@@ -414,7 +414,7 @@ private static function createRedirectResolver(array $options, string $host, str
 
             [$host, $port] = self::parseHostPort($url, $info);
 
-            if (false !== (parse_url($location, \PHP_URL_HOST) ?? false)) {
+            if (false !== (parse_url($location.'#', \PHP_URL_HOST) ?? false)) {
                 // Authorization and Cookie headers MUST NOT follow except for the initial host name
                 $requestHeaders = $redirectHeaders['host'] === $host && $redirectHeaders['port'] === $port ? $redirectHeaders['with_auth'] : $redirectHeaders['no_auth'];
                 $requestHeaders[] = 'Host: '.$host.$port;

src/Symfony/Component/HttpFoundation/BinaryFileResponse.php

@@ -217,8 +217,12 @@ public function prepare(Request $request): static
             }
             if ('x-accel-redirect' === strtolower($type)) {
                 // Do X-Accel-Mapping substitutions.
-                // @link https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/#x-accel-redirect
-                $parts = HeaderUtils::split($request->headers->get('X-Accel-Mapping', ''), ',=');
+                // @link https://github.com/rack/rack/blob/main/lib/rack/sendfile.rb
+                // @link https://mattbrictson.com/blog/accelerated-rails-downloads
+                if (!$request->headers->has('X-Accel-Mapping')) {
+                    throw new \LogicException('The "X-Accel-Mapping" header must be set when "X-Sendfile-Type" is set to "X-Accel-Redirect".');
+                }
+                $parts = HeaderUtils::split($request->headers->get('X-Accel-Mapping'), ',=');
                 foreach ($parts as $part) {
                     [$pathPrefix, $location] = $part;
                     if (str_starts_with($path, $pathPrefix)) {

src/Symfony/Component/HttpFoundation/Request.php

@@ -348,11 +348,12 @@ public static function create(string $uri, string $method = 'GET', array $parame
         $server['PATH_INFO'] = '';
         $server['REQUEST_METHOD'] = strtoupper($method);
 
-        $components = parse_url($uri);
-        if (false === $components) {
+        if (false === ($components = parse_url($uri)) && '/' === ($uri[0] ?? '')) {
             trigger_deprecation('symfony/http-foundation', '6.3', 'Calling "%s()" with an invalid URI is deprecated.', __METHOD__);
-            $components = [];
+            $components = parse_url($uri.'#');
+            unset($components['fragment']);
         }
+
         if (isset($components['host'])) {
             $server['SERVER_NAME'] = $components['host'];
             $server['HTTP_HOST'] = $components['host'];

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

@@ -263,6 +263,9 @@ public function testCreate()
         // Fragment should not be included in the URI
         $request = Request::create('http://test.com/foo#bar');
         $this->assertEquals('http://test.com/foo', $request->getUri());
+
+        $request = Request::create('/foo:123');
+        $this->assertEquals('http://localhost/foo:123', $request->getUri());
     }
 
     public function testCreateWithRequestUri()

src/Symfony/Component/Intl/Intl.php

@@ -106,7 +106,7 @@ public static function getIcuDataVersion(): string
      */
     public static function getIcuStubVersion(): string
     {
-        return '74.1';
+        return '75.1';
     }
 
     /**

src/Symfony/Component/Intl/Resources/bin/compile

@@ -1,6 +1,5 @@
 #!/usr/bin/env bash
 
-[[ $1 == force ]] && docker pull jakzal/php-intl:8.2-73.2
 [[ ! -d /tmp/symfony/icu ]] && mkdir -p /tmp/symfony/icu
 
 docker run \
@@ -9,5 +8,5 @@ docker run \
     -v /tmp/symfony/icu:/tmp \
     -v $(pwd):/symfony \
     -w /symfony \
-    jakzal/php-intl:8.2-73.2 \
+    jakzal/php-intl:8.3-74.1 \
     php src/Symfony/Component/Intl/Resources/bin/update-data.php

src/Symfony/Component/Intl/Resources/data/currencies/en.php

@@ -2,6 +2,6 @@ Git information
 ===============
 
 URL: https://github.com/unicode-org/icu.git
-Revision: 9edac7b78327a1cb58db29e2714b15f9fa14e4d7
-Author: Markus Scherer
-Date: 2023-10-27T15:04:44-07:00
+Revision: 7750081bda4b3bc1768ae03849ec70f67ea10625
+Author: DraganBesevic
+Date: 2024-04-15T15:52:50-07:00