minor symfony#44642 [Workflow] Fix Event constructor requirements (lyrixx)

nicolas-grekas · nicolas-grekas · commit 18c7edd2e481 · 2021-12-15T14:43:51.000+01:00
This PR was merged into the 5.3 branch. Discussion ---------- [Workflow] Fix Event constructor requirements | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | This has already been deprecied in 4.x But while cleaning the 5.x branch, I forgot to apply this patch See https://github.com/symfony/symfony/pull/31824/files#diff-5f386ffb0109cc731bd98e63eea021b32faadd98791bd6ba65926d09c5e2ec40L37 More over, `Event::getWorkflow()` has the correct return type. Commits ------- acc1cdb [Workflow] Fix Event constructor requirements
diff --git a/src/Symfony/Component/Workflow/Event/Event.php b/src/Symfony/Component/Workflow/Event/Event.php
@@ -29,7 +29,7 @@ class Event extends BaseEvent
     private $transition;
     private $workflow;
 
-    public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow = null, array $context = [])
+    public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow, array $context = [])
     {
         $this->subject = $subject;
         $this->marking = $marking;

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class Event extends BaseEvent`
`29`	`29`	`private $transition;`
`30`	`30`	`private $workflow;`
`31`	`31`
`32`		`- public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow = null, array $context = [])`
	`32`	`+ public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow, array $context = [])`
`33`	`33`	`{`
`34`	`34`	`$this->subject = $subject;`
`35`	`35`	`$this->marking = $marking;`