Skip to content

Commit 31e5dfb

Browse files
Merge branch '5.4' into 6.0
* 5.4: [DoctrineBridge] Treat firstResult === 0 like null [Translation] Refresh local translations if the provider has domains [HttpKernel] Fix SessionListener without session in request symfony#46268 [Notifier] Allow symfony/mercure 0.6 in Mercure bridge
2 parents 06b4706 + 1457491 commit 31e5dfb

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function getEntities(): array
5151
*/
5252
public function getEntitiesByIds(string $identifier, array $values): array
5353
{
54-
if (null !== $this->queryBuilder->getMaxResults() || null !== $this->queryBuilder->getFirstResult()) {
54+
if (null !== $this->queryBuilder->getMaxResults() || 0 < (int) $this->queryBuilder->getFirstResult()) {
5555
// an offset or a limit would apply on results including the where clause with submitted id values
5656
// that could make invalid choices valid
5757
$choices = [];

src/Symfony/Component/HttpKernel/Tests/EventListener/ResponseListenerTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function testSetContentLanguageHeaderWhenEmptyAndAtLeast2EnabledLocalesAr
102102
$request = Request::create('/');
103103
$request->setLocale('fr');
104104

105-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
105+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
106106
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
107107

108108
$this->assertEquals('fr', $response->headers->get('Content-Language'));
@@ -118,7 +118,7 @@ public function testNotOverrideContentLanguageHeaderWhenNotEmpty()
118118
$request = Request::create('/');
119119
$request->setLocale('de');
120120

121-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
121+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
122122
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
123123

124124
$this->assertEquals('mi, en', $response->headers->get('Content-Language'));
@@ -133,7 +133,7 @@ public function testNotSetContentLanguageHeaderWhenDisabled()
133133
$request = Request::create('/');
134134
$request->setLocale('fr');
135135

136-
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MASTER_REQUEST, $response);
136+
$event = new ResponseEvent($this->kernel, $request, HttpKernelInterface::MAIN_REQUEST, $response);
137137
$this->dispatcher->dispatch($event, KernelEvents::RESPONSE);
138138

139139
$this->assertNull($response->headers->get('Content-Language'));

src/Symfony/Component/HttpKernel/Tests/EventListener/SessionListenerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ public function testUninitializedSessionWithoutInitializedSession()
548548
$container = new ServiceLocator([]);
549549

550550
$listener = new SessionListener($container);
551-
$listener->onKernelResponse(new ResponseEvent($kernel, new Request(), HttpKernelInterface::MASTER_REQUEST, $response));
551+
$listener->onKernelResponse(new ResponseEvent($kernel, new Request(), HttpKernelInterface::MAIN_REQUEST, $response));
552552
$this->assertFalse($response->headers->has('Expires'));
553553
$this->assertTrue($response->headers->hasCacheControlDirective('public'));
554554
$this->assertFalse($response->headers->hasCacheControlDirective('private'));

src/Symfony/Component/Notifier/Bridge/Mercure/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"require": {
1919
"php": ">=8.0.2",
2020
"ext-json": "*",
21-
"symfony/mercure": "^0.5.2",
21+
"symfony/mercure": "^0.5.2|^0.6",
2222
"symfony/notifier": "^5.4|^6.0",
2323
"symfony/service-contracts": "^1.10|^2|^3"
2424
},

src/Symfony/Component/Security/Http/Tests/Firewall/ContextListenerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,10 +339,10 @@ public function testOnKernelResponseRemoveListener()
339339
$listener = new ContextListener($tokenStorage, [], 'session', null, $dispatcher, null, \Closure::fromCallable([$tokenStorage, 'getToken']));
340340
$this->assertEmpty($dispatcher->getListeners());
341341

342-
$listener(new RequestEvent($httpKernel, $request, HttpKernelInterface::MASTER_REQUEST));
342+
$listener(new RequestEvent($httpKernel, $request, HttpKernelInterface::MAIN_REQUEST));
343343
$this->assertNotEmpty($dispatcher->getListeners());
344344

345-
$listener->onKernelResponse(new ResponseEvent($httpKernel, $request, HttpKernelInterface::MASTER_REQUEST, new Response()));
345+
$listener->onKernelResponse(new ResponseEvent($httpKernel, $request, HttpKernelInterface::MAIN_REQUEST, new Response()));
346346
$this->assertEmpty($dispatcher->getListeners());
347347
}
348348

src/Symfony/Component/Translation/Command/TranslationPushCommand.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,16 +130,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
130130
$force = $input->getOption('force');
131131
$deleteMissing = $input->getOption('delete-missing');
132132

133+
if (!$domains && $provider instanceof FilteringProvider) {
134+
$domains = $provider->getDomains();
135+
}
136+
137+
// Reading local translations must be done after retrieving the domains from the provider
138+
// in order to manage only translations from configured domains
133139
$localTranslations = $this->readLocalTranslations($locales, $domains, $this->transPaths);
134140

135141
if (!$domains) {
136-
if ($provider instanceof FilteringProvider) {
137-
$domains = $provider->getDomains();
138-
}
139-
140-
if (!$domains) {
141-
$domains = $this->getDomainsFromTranslatorBag($localTranslations);
142-
}
142+
$domains = $this->getDomainsFromTranslatorBag($localTranslations);
143143
}
144144

145145
if (!$deleteMissing && $force) {

0 commit comments

Comments
 (0)