Merge branch '5.2' into 5.x

* 5.2:
  [DependencyInjection] Add missing bool type in procesValue()
  [CI] Make sure to restore default locale

Author: derrabus

src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php

@@ -78,7 +78,7 @@ public function __construct(bool $autoload = false, array $skippedIds = [])
     /**
      * {@inheritdoc}
      */
-    protected function processValue($value, $isRoot = false)
+    protected function processValue($value, bool $isRoot = false)
     {
         if (isset($this->skippedIds[$this->currentId])) {
             return $value;

src/Symfony/Component/Form/Tests/AbstractLayoutTest.php

@@ -26,13 +26,15 @@ abstract class AbstractLayoutTest extends FormIntegrationTestCase
 
     protected $csrfTokenManager;
     protected $testableFeatures = [];
+    private $defaultLocale;
 
     protected function setUp(): void
     {
         if (!\extension_loaded('intl')) {
             $this->markTestSkipped('Extension intl is required.');
         }
 
+        $this->defaultLocale = \Locale::getDefault();
         \Locale::setDefault('en');
 
         $this->csrfTokenManager = $this->createMock(CsrfTokenManagerInterface::class);
@@ -50,6 +52,7 @@ protected function getExtensions()
     protected function tearDown(): void
     {
         $this->csrfTokenManager = null;
+        \Locale::setDefault($this->defaultLocale);
 
         parent::tearDown();
     }

src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

@@ -23,6 +23,7 @@ class DateTimeToLocalizedStringTransformerTest extends TestCase
 
     protected $dateTime;
     protected $dateTimeWithoutSeconds;
+    private $defaultLocale;
 
     protected function setUp(): void
     {
@@ -37,6 +38,7 @@ protected function setUp(): void
         // Since we test against "de_AT", we need the full implementation
         IntlTestHelper::requireFullIntl($this, '57.1');
 
+        $this->defaultLocale = \Locale::getDefault();
         \Locale::setDefault('de_AT');
 
         $this->dateTime = new \DateTime('2010-02-03 04:05:06 UTC');
@@ -47,6 +49,7 @@ protected function tearDown(): void
     {
         $this->dateTime = null;
         $this->dateTimeWithoutSeconds = null;
+        \Locale::setDefault($this->defaultLocale);
     }
 
     public function dataProvider()

src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformerTest.php

@@ -19,15 +19,18 @@
 class MoneyToLocalizedStringTransformerTest extends TestCase
 {
     private $previousLocale;
+    private $defaultLocale;
 
     protected function setUp(): void
     {
         $this->previousLocale = setlocale(\LC_ALL, '0');
+        $this->defaultLocale = \Locale::getDefault();
     }
 
     protected function tearDown(): void
     {
         setlocale(\LC_ALL, $this->previousLocale);
+        \Locale::setDefault($this->defaultLocale);
     }
 
     public function testTransform()

src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php

@@ -18,13 +18,20 @@ class DateTimeTypeTest extends BaseTypeTest
 {
     public const TESTED_TYPE = 'Symfony\Component\Form\Extension\Core\Type\DateTimeType';
 
+    private $defaultLocale;
+
     protected function setUp(): void
     {
+        $this->defaultLocale = \Locale::getDefault();
         \Locale::setDefault('en');
-
         parent::setUp();
     }
 
+    protected function tearDown(): void
+    {
+        \Locale::setDefault($this->defaultLocale);
+    }
+
     public function testSubmitDateTime()
     {
         $form = $this->factory->create(static::TESTED_TYPE, null, [

src/Symfony/Component/Intl/Tests/ResourceBundleTestCase.php

@@ -724,13 +724,20 @@ abstract class ResourceBundleTestCase extends TestCase
     ];
 
     private static $rootLocales;
+    private $defaultLocale;
 
     protected function setUp(): void
     {
+        $this->defaultLocale = \Locale::getDefault();
         Locale::setDefault('en');
         Locale::setDefaultFallback('en');
     }
 
+    protected function tearDown(): void
+    {
+        \Locale::setDefault($this->defaultLocale);
+    }
+
     public function provideLocales()
     {
         return array_map(

src/Symfony/Contracts/Translation/Test/TranslatorTest.php

@@ -30,6 +30,18 @@
  */
 class TranslatorTest extends TestCase
 {
+    private $defaultLocale;
+
+    protected function setUp(): void
+    {
+        $this->defaultLocale = \Locale::getDefault();
+    }
+
+    protected function tearDown(): void
+    {
+        \Locale::setDefault($this->defaultLocale);
+    }
+
     public function getTranslator()
     {
         return new class() implements TranslatorInterface {