Skip to content

Commit 8d6f29a

Browse files
minor symfony#51087 [FrameworkBundle][Workflow] Clean code (lyrixx)
This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle][Workflow] Clean code | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- 4f8597f [Workflow] Cleaning code
2 parents 8b82019 + 4f8597f commit 8d6f29a

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed

src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,8 +398,6 @@
398398

399399
<xsd:simpleType name="marking_store_type">
400400
<xsd:restriction base="xsd:string">
401-
<xsd:enumeration value="multiple_state" />
402-
<xsd:enumeration value="single_state" />
403401
<xsd:enumeration value="method" />
404402
</xsd:restriction>
405403
</xsd:simpleType>

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/workflows.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<framework:workflow name="article" type="workflow">
1111
<framework:audit-trail enabled="true"/>
1212
<framework:initial-marking>draft</framework:initial-marking>
13-
<framework:marking-store type="method" property="state" />
1413
<framework:support>Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\FrameworkExtensionTestCase</framework:support>
1514
<framework:place name="draft" />
1615
<framework:place name="wait_for_journalist" />

src/Symfony/Component/Workflow/Tests/MarkingStore/MethodMarkingStoreTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Workflow\Tests\MarkingStore;
1313

1414
use PHPUnit\Framework\TestCase;
15-
use Symfony\Component\Workflow\Marking;
1615
use Symfony\Component\Workflow\MarkingStore\MethodMarkingStore;
1716
use Symfony\Component\Workflow\Tests\Subject;
1817

@@ -26,7 +25,6 @@ public function testGetSetMarkingWithMultipleState()
2625

2726
$marking = $markingStore->getMarking($subject);
2827

29-
$this->assertInstanceOf(Marking::class, $marking);
3028
$this->assertCount(0, $marking->getPlaces());
3129

3230
$marking->mark('first_place');
@@ -48,7 +46,6 @@ public function testGetSetMarkingWithSingleState()
4846

4947
$marking = $markingStore->getMarking($subject);
5048

51-
$this->assertInstanceOf(Marking::class, $marking);
5249
$this->assertCount(0, $marking->getPlaces());
5350

5451
$marking->mark('first_place');
@@ -70,7 +67,6 @@ public function testGetSetMarkingWithSingleStateAndAlmostEmptyPlaceName()
7067

7168
$marking = $markingStore->getMarking($subject);
7269

73-
$this->assertInstanceOf(Marking::class, $marking);
7470
$this->assertCount(1, $marking->getPlaces());
7571
}
7672

@@ -82,7 +78,6 @@ public function testGetMarkingWithValueObject()
8278

8379
$marking = $markingStore->getMarking($subject);
8480

85-
$this->assertInstanceOf(Marking::class, $marking);
8681
$this->assertCount(1, $marking->getPlaces());
8782
$this->assertSame('first_place', (string) $subject->getMarking());
8883
}
@@ -98,7 +93,6 @@ public function testGetMarkingWithUninitializedProperty()
9893

9994
$marking = $markingStore->getMarking($subject);
10095

101-
$this->assertInstanceOf(Marking::class, $marking);
10296
$this->assertCount(0, $marking->getPlaces());
10397
}
10498

0 commit comments

Comments
 (0)