bug symfony#48428 Fixed undefined variable error (Kevin Meijer)

fabpot · fabpot · commit c2172e703552 · 2022-12-01T22:04:47.000+01:00
This PR was merged into the 6.2 branch. Discussion ---------- Fixed undefined variable error | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#48426 | License | MIT | Doc PR | n/a Fixes an undefined variable warning during ZSH autocomplete if no suggestions have been provided. Commits ------- f405bfd Fixed undefined variable error
diff --git a/src/Symfony/Component/Console/Completion/Output/ZshCompletionOutput.php b/src/Symfony/Component/Console/Completion/Output/ZshCompletionOutput.php
@@ -21,6 +21,7 @@ class ZshCompletionOutput implements CompletionOutputInterface
 {
     public function write(CompletionSuggestions $suggestions, OutputInterface $output): void
     {
+        $values = [];
         foreach ($suggestions->getValueSuggestions() as $value) {
             $values[] = $value->getValue().($value->getDescription() ? "\t".$value->getDescription() : '');
         }

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ class ZshCompletionOutput implements CompletionOutputInterface`
`21`	`21`	`{`
`22`	`22`	`public function write(CompletionSuggestions $suggestions, OutputInterface $output): void`
`23`	`23`	`{`
	`24`	`+ $values = [];`
`24`	`25`	`foreach ($suggestions->getValueSuggestions() as $value) {`
`25`	`26`	`$values[] = $value->getValue().($value->getDescription() ? "\t".$value->getDescription() : '');`
`26`	`27`	`}`