added configurable web server config (symfony#57)

* added configurable web server config

* removed function in favor of null coalescing operator

Author: andrewmy

README.md

@@ -187,6 +187,7 @@ The following environment variables can be set to change some Panther behaviors:
 * `PANTHER_WEB_SERVER_DIR`: to change the project's document root (default to `public/`)
 * `PANTHER_CHROME_DRIVER_BINARY`: to use another `chromedriver` binary, instead of relying on the ones already provided by Panther
 * `PANTHER_CHROME_ARGUMENTS`: to customize `chromedriver` arguments. You need to set `PANTHER_NO_HEADLESS` to fully customize.
+* `PANTHER_WEB_SERVER_PORT`: to change the web server's port (default to `9000`)
 
 ## Docker Integration
 

src/PantherTestCaseTrait.php

@@ -87,11 +87,10 @@ protected static function startWebServer(?string $webServerDir = null, string $h
         self::$baseUri = "http://$hostname:$port";
     }
 
-    /**
-     * @param array $kernelOptions An array of options to pass to the createKernel method
-     */
-    protected static function createPantherClient(string $hostname = '127.0.0.1', int $port = 9000, array $kernelOptions = []): PantherClient
+    protected static function createPantherClient(string $hostname = '127.0.0.1', ?int $port = null, array $kernelOptions = []): PantherClient
     {
+        $port = (int) ($port ?? $_SERVER['PANTHER_WEB_SERVER_PORT'] ?? 9000);
+
         self::startWebServer(null, $hostname, $port);
         if (null === self::$pantherClient) {
             self::$pantherClient = Client::createChromeClient(null, null, [], self::$baseUri);
@@ -104,15 +103,14 @@ protected static function createPantherClient(string $hostname = '127.0.0.1', in
         return self::$pantherClient;
     }
 
-    /**
-     * @param array $kernelOptions An array of options to pass to the createKernel method
-     */
-    protected static function createGoutteClient(string $hostname = '127.0.0.1', int $port = 9000, array $kernelOptions = []): GoutteClient
+    protected static function createGoutteClient(string $hostname = '127.0.0.1', ?int $port = null, array $kernelOptions = []): GoutteClient
     {
         if (!\class_exists(GoutteClient::class)) {
             throw new \RuntimeException('Goutte is not installed. Run "composer req fabpot/goutte".');
         }
 
+        $port = (int) ($port ?? $_SERVER['PANTHER_WEB_SERVER_PORT'] ?? 9000);
+
         self::startWebServer(null, $hostname, $port);
         if (null === self::$goutteClient) {
             $goutteClient = new GoutteClient();

tests/ClientTest.php

@@ -190,4 +190,14 @@ public function testCookie(callable $clientFactory, string $type)
         $cookieJar->expire('foo');
         $this->assertNull($cookieJar->get('foo'));
     }
+
+    /**
+     * @dataProvider clientFactoryProvider
+     */
+    public function testServerPort(callable $clientFactory): void
+    {
+        $expectedPort = $_SERVER['PANTHER_WEB_SERVER_PORT'] ?? '9000';
+        $client = $clientFactory();
+        $this->assertEquals($expectedPort, \mb_substr(self::$baseUri, -4));
+    }
 }