Skip to content

Commit 4c29129

Browse files
Krishna-13-cyberchencha3
Krishna-13-cyber
authored and
chencha3
committed
Enable exp10 libcall on linux (llvm#68736)
1 parent 1d34e91 commit 4c29129

File tree

4 files changed

+88
-42
lines changed

4 files changed

+88
-42
lines changed

‎llvm/lib/Analysis/TargetLibraryInfo.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -560,16 +560,12 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
560560
break;
561561
case Triple::Linux:
562562
// exp10, exp10f, exp10l is available on Linux (GLIBC) but are extremely
563-
// buggy prior to glibc version 2.18. Until this version is widely deployed
564-
// or we have a reasonable detection strategy, we cannot use exp10 reliably
565-
// on Linux.
566-
//
567-
// Fall through to disable all of them.
568-
[[fallthrough]];
569-
default:
570-
TLI.setUnavailable(LibFunc_exp10);
571-
TLI.setUnavailable(LibFunc_exp10f);
572-
TLI.setUnavailable(LibFunc_exp10l);
563+
// buggy prior to glibc version 2.18. As this version is so old, we
564+
// don't really need to worry about using exp10 on Linux.
565+
TLI.setAvailableWithName(LibFunc_exp10, "__exp10");
566+
TLI.setAvailableWithName(LibFunc_exp10f, "__exp10f");
567+
TLI.setAvailableWithName(LibFunc_exp10l, "__exp10l");
568+
break;
573569
}
574570

575571
// ffsl is available on at least Darwin, Mac OS X, iOS, FreeBSD, and
@@ -841,6 +837,9 @@ static void initialize(TargetLibraryInfoImpl &TLI, const Triple &T,
841837
TLI.setUnavailable(LibFunc_strndup);
842838
TLI.setUnavailable(LibFunc_strnlen);
843839
TLI.setUnavailable(LibFunc_toascii);
840+
TLI.setUnavailable(LibFunc_exp10);
841+
TLI.setUnavailable(LibFunc_exp10f);
842+
TLI.setUnavailable(LibFunc_exp10l);
844843
}
845844

846845
// As currently implemented in clang, NVPTX code has no standard library to

‎llvm/test/Transforms/InstCombine/double-float-shrink-1.ll

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,20 @@ define double @expm1_test2(float %f) {
224224
; exp10f() doesn't exist for this triple, so it doesn't shrink.
225225

226226
define float @exp10_test1(float %f) {
227-
; CHECK-LABEL: @exp10_test1(
228-
; CHECK-NEXT: [[CONV:%.*]] = fpext float [[F:%.*]] to double
229-
; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[CONV]])
230-
; CHECK-NEXT: [[CONV1:%.*]] = fptrunc double [[CALL]] to float
231-
; CHECK-NEXT: ret float [[CONV1]]
227+
; LINUX-LABEL: define float @exp10_test1(
228+
; LINUX-SAME: float [[F:%.*]]) {
229+
; LINUX-NEXT: [[EXP10F:%.*]] = call fast float @__exp10f(float [[F]])
230+
; LINUX-NEXT: ret float [[EXP10F]]
231+
;
232+
; MS64-LABEL: define float @exp10_test1(
233+
; MS64-SAME: float [[F:%.*]]) {
234+
; MS64-NEXT: [[EXP10F:%.*]] = call fast float @exp10f(float [[F]])
235+
; MS64-NEXT: ret float [[EXP10F]]
236+
;
237+
; MS32-LABEL: define float @exp10_test1(
238+
; MS32-SAME: float [[F:%.*]]) {
239+
; MS32-NEXT: [[EXP10F:%.*]] = call fast float @exp10f(float [[F]])
240+
; MS32-NEXT: ret float [[EXP10F]]
232241
;
233242
%conv = fpext float %f to double
234243
%call = call fast double @exp10(double %conv)

‎llvm/test/Transforms/InstCombine/pow-1.ll

Lines changed: 45 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -870,10 +870,30 @@ define float @test_simplify18(float %x) {
870870
; CHECK-EXP10-NEXT: [[__EXP10F:%.*]] = call float @__exp10f(float [[X]])
871871
; CHECK-EXP10-NEXT: ret float [[__EXP10F]]
872872
;
873-
; CHECK-NO-EXP10-LABEL: define float @test_simplify18(
874-
; CHECK-NO-EXP10-SAME: float [[X:%.*]]) {
875-
; CHECK-NO-EXP10-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
876-
; CHECK-NO-EXP10-NEXT: ret float [[RETVAL]]
873+
; VC32-LABEL: define float @test_simplify18(
874+
; VC32-SAME: float [[X:%.*]]) {
875+
; VC32-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
876+
; VC32-NEXT: ret float [[RETVAL]]
877+
;
878+
; VC51-LABEL: define float @test_simplify18(
879+
; VC51-SAME: float [[X:%.*]]) {
880+
; VC51-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
881+
; VC51-NEXT: ret float [[RETVAL]]
882+
;
883+
; VC64-LABEL: define float @test_simplify18(
884+
; VC64-SAME: float [[X:%.*]]) {
885+
; VC64-NEXT: [[EXP10F:%.*]] = call float @exp10f(float [[X]])
886+
; VC64-NEXT: ret float [[EXP10F]]
887+
;
888+
; VC83-LABEL: define float @test_simplify18(
889+
; VC83-SAME: float [[X:%.*]]) {
890+
; VC83-NEXT: [[EXP10F:%.*]] = call float @exp10f(float [[X]])
891+
; VC83-NEXT: ret float [[EXP10F]]
892+
;
893+
; NOLIB-LABEL: define float @test_simplify18(
894+
; NOLIB-SAME: float [[X:%.*]]) {
895+
; NOLIB-NEXT: [[RETVAL:%.*]] = call float @powf(float 1.000000e+01, float [[X]])
896+
; NOLIB-NEXT: ret float [[RETVAL]]
877897
;
878898
%retval = call float @powf(float 10.0, float %x)
879899
ret float %retval
@@ -885,11 +905,28 @@ define double @test_simplify19(double %x) {
885905
; CHECK-EXP10-NEXT: [[__EXP10:%.*]] = call double @__exp10(double [[X]])
886906
; CHECK-EXP10-NEXT: ret double [[__EXP10]]
887907
;
888-
; CHECK-NO-EXP10-LABEL: define double @test_simplify19(
889-
; CHECK-NO-EXP10-SAME: double [[X:%.*]]) {
890-
; CHECK-NO-EXP10-NEXT: [[RETVAL:%.*]] = call double @pow(double 1.000000e+01, double [[X]])
891-
; CHECK-NO-EXP10-NEXT: ret double [[RETVAL]]
908+
; VC32-LABEL: define double @test_simplify19(
909+
; VC32-SAME: double [[X:%.*]]) {
910+
; VC32-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
911+
; VC32-NEXT: ret double [[EXP10]]
912+
;
913+
; VC19-LABEL: define double @test_simplify19(
914+
; VC19-SAME: double [[X:%.*]]) {
915+
; VC19-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
916+
; VC19-NEXT: ret double [[EXP10]]
917+
;
918+
; VC64-LABEL: define double @test_simplify19(
919+
; VC64-SAME: double [[X:%.*]]) {
920+
; VC64-NEXT: [[EXP10:%.*]] = call double @exp10(double [[X]])
921+
; VC64-NEXT: ret double [[EXP10]]
922+
;
923+
; NOLIB-LABEL: define double @test_simplify19(
924+
; NOLIB-SAME: double [[X:%.*]]) {
925+
; NOLIB-NEXT: [[RETVAL:%.*]] = call double @pow(double 1.000000e+01, double [[X]])
926+
; NOLIB-NEXT: ret double [[RETVAL]]
892927
;
893928
%retval = call double @pow(double 10.0, double %x)
894929
ret double %retval
895930
}
931+
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
932+
; CHECK-NO-EXP10: {{.*}}

‎llvm/test/Transforms/InstCombine/pow-exp.ll

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,11 @@ define fp128 @powl_exp2l_not_fast(fp128 %x, fp128 %y) {
136136
ret fp128 %pow
137137
}
138138

139-
; TODO: exp10() is not widely enabled by many targets yet.
140-
141139
define float @powf_exp10f(float %x, float %y) {
142-
; CHECK-LABEL: @powf_exp10f(
143-
; CHECK-NEXT: [[CALL:%.*]] = call fast float @exp10f(float [[X:%.*]]) #[[ATTR1:[0-9]+]]
144-
; CHECK-NEXT: [[POW:%.*]] = call fast float @llvm.pow.f32(float [[CALL]], float [[Y:%.*]])
140+
; CHECK-LABEL: define float @powf_exp10f(
141+
; CHECK-SAME: float [[X:%.*]], float [[Y:%.*]]) {
142+
; CHECK-NEXT: [[CALL:%.*]] = call fast float @exp10f(float [[X]]) #[[ATTR1:[0-9]+]]
143+
; CHECK-NEXT: [[POW:%.*]] = call fast float @llvm.pow.f32(float [[CALL]], float [[Y]])
145144
; CHECK-NEXT: ret float [[POW]]
146145
;
147146
%call = call fast float @exp10f(float %x) nounwind readnone
@@ -150,9 +149,10 @@ define float @powf_exp10f(float %x, float %y) {
150149
}
151150

152151
define double @pow_exp10(double %x, double %y) {
153-
; CHECK-LABEL: @pow_exp10(
154-
; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[X:%.*]]) #[[ATTR1]]
155-
; CHECK-NEXT: [[POW:%.*]] = call fast double @llvm.pow.f64(double [[CALL]], double [[Y:%.*]])
152+
; CHECK-LABEL: define double @pow_exp10(
153+
; CHECK-SAME: double [[X:%.*]], double [[Y:%.*]]) {
154+
; CHECK-NEXT: [[CALL:%.*]] = call fast double @exp10(double [[X]]) #[[ATTR1]]
155+
; CHECK-NEXT: [[POW:%.*]] = call fast double @llvm.pow.f64(double [[CALL]], double [[Y]])
156156
; CHECK-NEXT: ret double [[POW]]
157157
;
158158
%call = call fast double @exp10(double %x) nounwind readnone
@@ -161,9 +161,10 @@ define double @pow_exp10(double %x, double %y) {
161161
}
162162

163163
define fp128 @pow_exp10l(fp128 %x, fp128 %y) {
164-
; CHECK-LABEL: @pow_exp10l(
165-
; CHECK-NEXT: [[CALL:%.*]] = call fast fp128 @exp10l(fp128 [[X:%.*]]) #[[ATTR1]]
166-
; CHECK-NEXT: [[POW:%.*]] = call fast fp128 @llvm.pow.f128(fp128 [[CALL]], fp128 [[Y:%.*]])
164+
; CHECK-LABEL: define fp128 @pow_exp10l(
165+
; CHECK-SAME: fp128 [[X:%.*]], fp128 [[Y:%.*]]) {
166+
; CHECK-NEXT: [[CALL:%.*]] = call fast fp128 @exp10l(fp128 [[X]]) #[[ATTR1]]
167+
; CHECK-NEXT: [[POW:%.*]] = call fast fp128 @llvm.pow.f128(fp128 [[CALL]], fp128 [[Y]])
167168
; CHECK-NEXT: ret fp128 [[POW]]
168169
;
169170
%call = call fast fp128 @exp10l(fp128 %x) nounwind readnone
@@ -255,10 +256,10 @@ define double @pow_ok_base3(double %e) {
255256
}
256257

257258
define double @pow_ok_ten_base(double %e) {
258-
; CHECK-LABEL: @pow_ok_ten_base(
259-
; CHECK-NEXT: [[MUL:%.*]] = fmul nnan ninf afn double [[E:%.*]], 0x400A934F{{.*}}
260-
; CHECK-NEXT: [[EXP2:%.*]] = tail call nnan ninf afn double @exp2(double [[MUL]])
261-
; CHECK-NEXT: ret double [[EXP2]]
259+
; CHECK-LABEL: define double @pow_ok_ten_base(
260+
; CHECK-SAME: double [[E:%.*]]) {
261+
; CHECK-NEXT: [[EXP10:%.*]] = tail call nnan ninf afn double @exp10(double [[E]])
262+
; CHECK-NEXT: ret double [[EXP10]]
262263
;
263264
%call = tail call afn nnan ninf double @pow(double 1.000000e+01, double %e)
264265
ret double %call
@@ -305,10 +306,10 @@ define float @powf_ok_base3(float %e) {
305306
}
306307

307308
define float @powf_ok_ten_base(float %e) {
308-
; CHECK-LABEL: @powf_ok_ten_base(
309-
; CHECK-NEXT: [[MUL:%.*]] = fmul nnan ninf afn float [[E:%.*]], 0x400A934{{.*}}
310-
; CHECK-NEXT: [[EXP2F:%.*]] = tail call nnan ninf afn float @exp2f(float [[MUL]])
311-
; CHECK-NEXT: ret float [[EXP2F]]
309+
; CHECK-LABEL: define float @powf_ok_ten_base(
310+
; CHECK-SAME: float [[E:%.*]]) {
311+
; CHECK-NEXT: [[EXP10F:%.*]] = tail call nnan ninf afn float @exp10f(float [[E]])
312+
; CHECK-NEXT: ret float [[EXP10F]]
312313
;
313314
%call = tail call afn nnan ninf float @powf(float 1.000000e+01, float %e)
314315
ret float %call

0 commit comments

Comments
 (0)