Skip to content

Commit 85d5265

Browse files
paperchalicechencha3
authored andcommitted
Revert "[Passes] Expose parseSinglePassOption" (llvm#86225)
Reverts llvm#86117
1 parent 70a7345 commit 85d5265

File tree

2 files changed

+24
-38
lines changed

2 files changed

+24
-38
lines changed

llvm/include/llvm/Passes/PassBuilder.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -672,13 +672,6 @@ class PassBuilder {
672672
return Result;
673673
}
674674

675-
/// Handle passes only accept one bool-valued parameter.
676-
///
677-
/// \return false when Params is empty.
678-
static Expected<bool> parseSinglePassOption(StringRef Params,
679-
StringRef OptionName,
680-
StringRef PassName);
681-
682675
private:
683676
// O1 pass pipeline
684677
FunctionPassManager

llvm/lib/Passes/PassBuilder.cpp

Lines changed: 24 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -600,9 +600,8 @@ Expected<LoopUnrollOptions> parseLoopUnrollOptions(StringRef Params) {
600600
return UnrollOpts;
601601
}
602602

603-
Expected<bool> PassBuilder::parseSinglePassOption(StringRef Params,
604-
StringRef OptionName,
605-
StringRef PassName) {
603+
Expected<bool> parseSinglePassOption(StringRef Params, StringRef OptionName,
604+
StringRef PassName) {
606605
bool Result = false;
607606
while (!Params.empty()) {
608607
StringRef ParamName;
@@ -621,28 +620,24 @@ Expected<bool> PassBuilder::parseSinglePassOption(StringRef Params,
621620
}
622621

623622
Expected<bool> parseGlobalDCEPassOptions(StringRef Params) {
624-
return PassBuilder::parseSinglePassOption(
625-
Params, "vfe-linkage-unit-visibility", "GlobalDCE");
623+
return parseSinglePassOption(Params, "vfe-linkage-unit-visibility", "GlobalDCE");
626624
}
627625

628626
Expected<bool> parseCGProfilePassOptions(StringRef Params) {
629-
return PassBuilder::parseSinglePassOption(Params, "in-lto-post-link",
630-
"CGProfile");
627+
return parseSinglePassOption(Params, "in-lto-post-link", "CGProfile");
631628
}
632629

633630
Expected<bool> parseInlinerPassOptions(StringRef Params) {
634-
return PassBuilder::parseSinglePassOption(Params, "only-mandatory",
635-
"InlinerPass");
631+
return parseSinglePassOption(Params, "only-mandatory", "InlinerPass");
636632
}
637633

638634
Expected<bool> parseCoroSplitPassOptions(StringRef Params) {
639-
return PassBuilder::parseSinglePassOption(Params, "reuse-storage",
640-
"CoroSplitPass");
635+
return parseSinglePassOption(Params, "reuse-storage", "CoroSplitPass");
641636
}
642637

643638
Expected<bool> parsePostOrderFunctionAttrsPassOptions(StringRef Params) {
644-
return PassBuilder::parseSinglePassOption(
645-
Params, "skip-non-recursive-function-attrs", "PostOrderFunctionAttrs");
639+
return parseSinglePassOption(Params, "skip-non-recursive-function-attrs",
640+
"PostOrderFunctionAttrs");
646641
}
647642

648643
Expected<CFGuardPass::Mechanism> parseCFGuardPassOptions(StringRef Params) {
@@ -666,21 +661,19 @@ Expected<CFGuardPass::Mechanism> parseCFGuardPassOptions(StringRef Params) {
666661
}
667662

668663
Expected<bool> parseEarlyCSEPassOptions(StringRef Params) {
669-
return PassBuilder::parseSinglePassOption(Params, "memssa", "EarlyCSE");
664+
return parseSinglePassOption(Params, "memssa", "EarlyCSE");
670665
}
671666

672667
Expected<bool> parseEntryExitInstrumenterPassOptions(StringRef Params) {
673-
return PassBuilder::parseSinglePassOption(Params, "post-inline",
674-
"EntryExitInstrumenter");
668+
return parseSinglePassOption(Params, "post-inline", "EntryExitInstrumenter");
675669
}
676670

677671
Expected<bool> parseLoopExtractorPassOptions(StringRef Params) {
678-
return PassBuilder::parseSinglePassOption(Params, "single", "LoopExtractor");
672+
return parseSinglePassOption(Params, "single", "LoopExtractor");
679673
}
680674

681675
Expected<bool> parseLowerMatrixIntrinsicsPassOptions(StringRef Params) {
682-
return PassBuilder::parseSinglePassOption(Params, "minimal",
683-
"LowerMatrixIntrinsics");
676+
return parseSinglePassOption(Params, "minimal", "LowerMatrixIntrinsics");
684677
}
685678

686679
Expected<AddressSanitizerOptions> parseASanPassOptions(StringRef Params) {
@@ -1020,13 +1013,13 @@ parseStackLifetimeOptions(StringRef Params) {
10201013
}
10211014

10221015
Expected<bool> parseDependenceAnalysisPrinterOptions(StringRef Params) {
1023-
return PassBuilder::parseSinglePassOption(Params, "normalized-results",
1024-
"DependenceAnalysisPrinter");
1016+
return parseSinglePassOption(Params, "normalized-results",
1017+
"DependenceAnalysisPrinter");
10251018
}
10261019

10271020
Expected<bool> parseSeparateConstOffsetFromGEPPassOptions(StringRef Params) {
1028-
return PassBuilder::parseSinglePassOption(Params, "lower-gep",
1029-
"SeparateConstOffsetFromGEP");
1021+
return parseSinglePassOption(Params, "lower-gep",
1022+
"SeparateConstOffsetFromGEP");
10301023
}
10311024

10321025
Expected<OptimizationLevel>
@@ -1042,13 +1035,13 @@ parseFunctionSimplificationPipelineOptions(StringRef Params) {
10421035
}
10431036

10441037
Expected<bool> parseMemorySSAPrinterPassOptions(StringRef Params) {
1045-
return PassBuilder::parseSinglePassOption(Params, "no-ensure-optimized-uses",
1046-
"MemorySSAPrinterPass");
1038+
return parseSinglePassOption(Params, "no-ensure-optimized-uses",
1039+
"MemorySSAPrinterPass");
10471040
}
10481041

10491042
Expected<bool> parseSpeculativeExecutionPassOptions(StringRef Params) {
1050-
return PassBuilder::parseSinglePassOption(Params, "only-if-divergent-target",
1051-
"SpeculativeExecutionPass");
1043+
return parseSinglePassOption(Params, "only-if-divergent-target",
1044+
"SpeculativeExecutionPass");
10521045
}
10531046

10541047
Expected<std::string> parseMemProfUsePassOptions(StringRef Params) {
@@ -1069,13 +1062,13 @@ Expected<std::string> parseMemProfUsePassOptions(StringRef Params) {
10691062
}
10701063

10711064
Expected<bool> parseStructuralHashPrinterPassOptions(StringRef Params) {
1072-
return PassBuilder::parseSinglePassOption(Params, "detailed",
1073-
"StructuralHashPrinterPass");
1065+
return parseSinglePassOption(Params, "detailed",
1066+
"StructuralHashPrinterPass");
10741067
}
10751068

10761069
Expected<bool> parseWinEHPrepareOptions(StringRef Params) {
1077-
return PassBuilder::parseSinglePassOption(Params, "demote-catchswitch-only",
1078-
"WinEHPreparePass");
1070+
return parseSinglePassOption(Params, "demote-catchswitch-only",
1071+
"WinEHPreparePass");
10791072
}
10801073

10811074
Expected<GlobalMergeOptions> parseGlobalMergeOptions(StringRef Params) {

0 commit comments

Comments
 (0)