appveyor.yml: ensure tests are functional on Windows

Author: ttaylorr

appveyor.yml

@@ -1,18 +1,23 @@
+image: Visual Studio 2017
+
 skip_branch_with_pr: true
 
 environment:
+  GIT_LFS_NO_TEST_COUNT: 1
   GOPATH: $(HOMEDRIVE)$(HOMEPATH)\go
   MSYSTEM: MINGW64
 
 clone_folder: $(GOPATH)\src\github.com\git-lfs\git-lfs
 
 install:
   - rd C:\Go /s /q
+  - rd C:\Perl /s /q
+  - refreshenv
   - cinst golang --version 1.8.3 -y
   - cinst InnoSetup -y
+  - cinst strawberryperl -y
+  - refreshenv
   - cinst make
-  - cpan App::cpanminus
-  - cpanm TAP::Harness::Env
   - refreshenv
   - ps: |
       echo "Go directories in machine PATH environment:"

script/cibuild

@@ -12,5 +12,15 @@ pushd t >/dev/null
   if [[ $UNAME == MINGW* || $UNAME == MSYS* || $UNAME == CYGWIN* ]]; then
     X=".exe"
   fi
-  VERBOSE_LOGS=1 make X="$X" clean && make X="$X" PROVE_EXTRA_ARGS=-j9
+
+  PROVE="prove"
+  PROVE_EXTRA_ARGS="-j9"
+  if [ -n "$APPVEYOR" ]; then
+    export PATH="/c/Strawberry/perl/bin:.:$PATH"
+    PROVE="prove.bat"
+    PROVE_EXTRA_ARGS="$PROVE_EXTRA_ARGS --exec bash"
+  fi
+
+  VERBOSE_LOGS=1 make X="$X" clean
+  VERBOSE_LOGS=1 make X="$X" PROVE="$PROVE" PROVE_EXTRA_ARGS="$PROVE_EXTRA_ARGS"
 popd >/dev/null

t/Makefile

@@ -23,13 +23,13 @@ all : $(DEFAULT_TEST_TARGET)
 
 test : $(TEST_CMDS)
 	$(RM) -r remote test_count{,.lock}
-	bash -c '. ./testenv.sh && setup'
-	prove $(PROVE_EXTRA_ARGS) ./t-*.sh
-	bash -c '. ./testenv.sh && shutdown'
+	@GIT_LFS_NO_TEST_COUNT= bash -c '. ./testenv.sh && setup'
+	$(PROVE) $(PROVE_EXTRA_ARGS) ./t-*.sh
+	@GIT_LFS_NO_TEST_COUNT= bash -c '. ./testenv.sh && shutdown'
 
 ./t-%.sh : $(TEST_CMDS)
 	$(RM) -r remote test_count{,.lock}
-	prove -v $(PROVE_EXTRA_ARGS) $@
+	$(PROVE) -v $(PROVE_EXTRA_ARGS) $@
 
 .PHONY : clean
 clean :

t/testhelpers.sh

@@ -505,14 +505,16 @@ setup() {
   git lfs version | sed -e 's/^/# /g'
   git version | sed -e 's/^/# /g'
 
-  LFSTEST_URL="$LFS_URL_FILE" \
-  LFSTEST_SSL_URL="$LFS_SSL_URL_FILE" \
-  LFSTEST_CLIENT_CERT_URL="$LFS_CLIENT_CERT_URL_FILE" \
-  LFSTEST_DIR="$REMOTEDIR" \
-  LFSTEST_CERT="$LFS_CERT_FILE" \
-  LFSTEST_CLIENT_CERT="$LFS_CLIENT_CERT_FILE" \
-  LFSTEST_CLIENT_KEY="$LFS_CLIENT_KEY_FILE" \
-    lfstest-count-tests increment
+  if [ -z "$GIT_LFS_NO_TEST_COUNT" ]; then
+    LFSTEST_URL="$LFS_URL_FILE" \
+    LFSTEST_SSL_URL="$LFS_SSL_URL_FILE" \
+    LFSTEST_CLIENT_CERT_URL="$LFS_CLIENT_CERT_URL_FILE" \
+    LFSTEST_DIR="$REMOTEDIR" \
+    LFSTEST_CERT="$LFS_CERT_FILE" \
+    LFSTEST_CLIENT_CERT="$LFS_CLIENT_CERT_FILE" \
+    LFSTEST_CLIENT_KEY="$LFS_CLIENT_KEY_FILE" \
+      lfstest-count-tests increment
+  fi
 
   wait_for_file "$LFS_URL_FILE"
   wait_for_file "$LFS_SSL_URL_FILE"
@@ -564,9 +566,11 @@ shutdown() {
   # every t/t-*.sh file should cleanup its trashdir
   [ -z "$KEEPTRASH" ] && rm -rf "$TRASHDIR"
 
-  LFSTEST_DIR="$REMOTEDIR" \
-  LFS_URL_FILE="$LFS_URL_FILE" \
-    lfstest-count-tests decrement
+  if [ -z "$GIT_LFS_NO_TEST_COUNT" ]; then
+    LFSTEST_DIR="$REMOTEDIR" \
+    LFS_URL_FILE="$LFS_URL_FILE" \
+      lfstest-count-tests decrement
+  fi
 }
 
 tap_show_plan() {