Delete hacky reorderFields method

Author: connorkuehl

clang/include/clang/AST/Decl.h

@@ -3814,8 +3814,6 @@ class RecordDecl : public TagDecl {
   /// nullptr is returned if no named data member exists.
   const FieldDecl *findFirstNamedDataMember() const;
 
-  void reorderFields(ArrayRef<Decl *> Decls) const;
-
 private:
   /// Deserialize just the fields.
   void LoadFieldsFromExternalStorage() const;

clang/lib/AST/Decl.cpp

@@ -4148,14 +4148,6 @@ RecordDecl::field_iterator RecordDecl::field_begin() const {
   return field_iterator(decl_iterator(FirstDecl));
 }
 
-void RecordDecl::reorderFields(ArrayRef<Decl *> Decls) const {
-  Decl *NewFirst, *NewLast;
-  std::tie(NewFirst, NewLast) =
-      BuildDeclChain(Decls, false);
-  FirstDecl = NewFirst;
-  LastDecl = NewLast;
-}
-
 /// completeDefinition - Notes that the definition of this type is now
 /// complete.
 void RecordDecl::completeDefinition() {

clang/lib/AST/RecordLayoutBuilder.cpp

@@ -2989,16 +2989,6 @@ ASTContext::getASTRecordLayout(const RecordDecl *D) const {
 
   bool ShouldBeRandomized = D->getAttr<RandomizeLayoutAttr>() != nullptr;
   if (ShouldBeRandomized) {
-      // A staging area to easily reorder the fields
-      SmallVector<Decl *, 64> fields;
-      for (auto f : D->fields()) {
-        fields.push_back(f);
-      }
-
-      fields = rearrange(*this, fields);
-
-      // This will rebuild the Decl chain of fields
-      D->reorderFields(fields);
   }
 
   if (isMsLayout(*this)) {