Add DiagGroup to NoRandomizeLayout attribute

connorkuehl · connorkuehl · commit f94de0689a02 · 2019-02-23T05:56:15.000Z
All attributes that emit warnings are required
to be members of a warning group; this is checked
by the clang-test regression suite.
diff --git a/clang/include/clang/Basic/DiagnosticASTKinds.td b/clang/include/clang/Basic/DiagnosticASTKinds.td
@@ -347,6 +347,6 @@ def warn_unnecessary_packed : Warning<
 // RandStruct implementation
 def warn_randomize_attr_conflict : Warning<
   "struct declared with 'randomize_layout' and 'no_randomize_layout' attributes;"
-  "attribute 'no_randomize_layout' takes precedence">;
+  "attribute 'no_randomize_layout' takes precedence">, InGroup<DiagGroup<"no-randomize-layout">>;
 
 }

Original file line number	Diff line number	Diff line change
`@@ -347,6 +347,6 @@ def warn_unnecessary_packed : Warning<`
`347`	`347`	`// RandStruct implementation`
`348`	`348`	`def warn_randomize_attr_conflict : Warning<`
`349`	`349`	`"struct declared with 'randomize_layout' and 'no_randomize_layout' attributes;"`
`350`		`- "attribute 'no_randomize_layout' takes precedence">;`
	`350`	`+ "attribute 'no_randomize_layout' takes precedence">, InGroup<DiagGroup<"no-randomize-layout">>;`
`351`	`351`
`352`	`352`	`}`