Remove optional domain attribute from aws_eip resource (#173)

mariot8 · joe-niland · hans-d · web-flow · commit 5dd574de9490 · 2024-03-20T13:13:38.000+11:00
Co-authored-by: Joe Niland &lt;joe@originalmind.com.au&gt;
Co-authored-by: Hans Donner &lt;hans@hansdonner.nl&gt;
diff --git a/eni.tf b/eni.tf
@@ -26,6 +26,5 @@ resource "aws_network_interface_attachment" "additional" {
 resource "aws_eip" "additional" {
   #bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
   count             = local.additional_ips_count
-  domain            = "vpc"
   network_interface = aws_network_interface.additional[count.index].id
 }
diff --git a/main.tf b/main.tf
@@ -178,7 +178,6 @@ resource "aws_eip" "default" {
   #bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
   count    = var.associate_public_ip_address && var.assign_eip_address && module.this.enabled ? 1 : 0
   instance = one(aws_instance.default[*].id)
-  domain   = "vpc"
   tags     = module.this.tags
 }
 

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,5 @@ resource "aws_network_interface_attachment" "additional" {`
`26`	`26`	`resource "aws_eip" "additional" {`
`27`	`27`	#bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
`28`	`28`	`count = local.additional_ips_count`
`29`		`- domain = "vpc"`
`30`	`29`	`network_interface = aws_network_interface.additional[count.index].id`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,6 @@ resource "aws_eip" "default" {`
`178`	`178`	#bridgecrew:skip=BC_AWS_NETWORKING_48: Skiping `Ensure all EIP addresses allocated to a VPC are attached to EC2 instances` because it is incorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
`179`	`179`	`count = var.associate_public_ip_address && var.assign_eip_address && module.this.enabled ? 1 : 0`
`180`	`180`	`instance = one(aws_instance.default[*].id)`
`181`		`- domain = "vpc"`
`182`	`181`	`tags = module.this.tags`
`183`	`182`	`}`
`184`	`183`