Fix phpGH-17717: Socket maximum timeout of 2147 seconds?

The fix for phpGH-16809[1] used a way too small timeout maximum on
Windows.  We correct this.

However, later on the timeout is applied to the current timestamp, so
we would need to take that into account, but due to the elapsed time
between the check and the actual network request, this could not be
precise, and the resulting error message would be confusing, since
after the developer would adjust the timeout to the reported maximum,
the check would fail again, now reporting a lower maximum timeout.

Thus we silently cap the value in `php_network_set_limit_time()` to
avoid undefined behavior, and are not picky about the usec value (we
just assume a second more), since there is a bigger issue, namely that
we hit the Y2038 problem on Windows.

[1] <php#16810>

Author: cmb69

ext/standard/http_fopen_wrapper.c

@@ -219,7 +219,7 @@ static php_stream *php_stream_url_wrap_http_ex(php_stream_wrapper *wrapper,
 #ifndef PHP_WIN32
 		const double timeoutmax = (double) PHP_TIMEOUT_ULL_MAX / 1000000.0;
 #else
-		const double timeoutmax = (double) LONG_MAX / 1000000.0;
+		const double timeoutmax = (double) LONG_MAX + 0.999999;
 #endif
 
 		if (d > timeoutmax) {

main/network.c

@@ -319,6 +319,14 @@ static inline void php_network_set_limit_time(struct timeval *limit_time,
 		struct timeval *timeout)
 {
 	gettimeofday(limit_time, NULL);
+# ifdef PHP_WIN32
+	/* cap timeout (we're not picky regarding usec) */
+	if (limit_time->tv_sec > (LONG_MAX - timeout->tv_sec) + 1) {
+		limit_time->tv_sec = LONG_MAX;
+		limit_time->tv_usec = 999999;
+		return;
+	}
+# endif
 	limit_time->tv_sec += timeout->tv_sec;
 	limit_time->tv_usec += timeout->tv_usec;
 	if (limit_time->tv_usec >= 1000000) {