Skip to content

Add UVI API #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Add UVI API #97

wants to merge 10 commits into from

Conversation

peter279k
Copy link
Contributor

Change log

  • Add UVI API.
  • Remove allow_failures configuration.

I'm not sure it's the proper way to implement the UVI API.
Please review this.

Thanks.

@peter279k peter279k mentioned this pull request Feb 6, 2017
- php: nightly

before_install:
- if [[ ! $TRAVIS_PHP_VERSION = hhvm* ]]; then phpenv config-rm xdebug.ini || echo "xdebug not available"; fi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert these changes or reason why you made them?

@peter279k
Copy link
Contributor Author

Hi @cmfcmf, I remove the nightly because I think the master branch should be passed by the nightly,
And it shouldn't allow failures.

Secondly, I move the if [[ ! $TRAVIS_PHP_VERSION = hhvm* ]]; then phpenv config-rm xdebug.ini || echo "xdebug not available"; fi to the install step.

Thanks.

@cmfcmf cmfcmf mentioned this pull request Feb 7, 2017
@cmfcmf
Copy link
Owner

cmfcmf commented Feb 7, 2017

I think the master branch should be passed by the nightly,

I must disagree here, I've reverted this change in my PR #99.
Please take a look at #99. It includes most of your changes plus a few adjustments. Thank you for your work!

@cmfcmf cmfcmf closed this Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants