Skip to content

Updated README #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Updated README #9

merged 3 commits into from
Jan 17, 2018

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Jan 16, 2018

Removed a few things, but I think the guide is still comprehensive. Any FAQs?

@sunjay
Copy link
Collaborator

sunjay commented Jan 16, 2018

Hi @TomPed! Thanks for taking the time to take a look at this!

Could you explain your changes a bit more? You have deleted a lot of the README without much justification and it would help me review if you could explain why you needed to completely change how it was structured.

For future reference, several smaller PRs are usually better than one big one. If you are updating the commands or the configuration file, doing that first and only making the minimal changes necessary is usually the best way to get things merged quickly and easily. :)

@TomPed
Copy link
Contributor Author

TomPed commented Jan 16, 2018

We want a somewhat standard README.md setup across all of the Codecov examples. I kept all of the steps (I believe 😄 ), I've just moved them under different headers.

@TomPed
Copy link
Contributor Author

TomPed commented Jan 16, 2018

I did however remove the talk about other CIs. I can add that back.

@sunjay
Copy link
Collaborator

sunjay commented Jan 16, 2018

We want a somewhat standard README.md setup across all of the Codecov examples.

Ah okay. Should have started with that. 😄

That should all be fine. I read through the updated README and it looks good. Please do add back the stuff about the other CIs. That information is useful for people not using Travis CI.

I'm good to merge this once those changes are made. Appreciate you taking the time to update this! 😄

@TomPed
Copy link
Contributor Author

TomPed commented Jan 16, 2018

Updated. Yeah sorry about that, I should have gave some context 😆 . Thanks!

@sunjay
Copy link
Collaborator

sunjay commented Jan 17, 2018

This is good from my end. I would merge it in myself but it seems I no longer have write access even though I've been maintaining this example since I created it over a year ago. Could you find out how I can get my access back?

@stevepeak
Copy link

@sunjay I'm adding you back with write access 👍

@stevepeak stevepeak merged commit 68fab58 into codecov:master Jan 17, 2018
@sunjay
Copy link
Collaborator

sunjay commented Jan 17, 2018

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants