Properly reset test folder on each test

Author: Holger Lösken

tests/Models/UpdateExecutorTest.php

@@ -51,8 +51,19 @@ public function it_can_run_successfully(): void
         $this->release->extract();
 
         $updateExecutor = (new UpdateExecutor())->setBasePath($dir);
-        $this->assertTrue($updateExecutor->run($this->release));
 
+        $this->assertTrue($updateExecutor->run($this->release));
+        $this->assertTrue(File::exists($dir . '/.some-hidden-file'));
+        $this->assertTrue(File::exists($dir . '/outer-file.txt'));
+        $this->assertTrue(File::exists($dir . '/folder1'));
+        $this->assertEmpty(File::allFiles($dir . '/folder1'));
+        $this->assertTrue(File::exists($dir . '/folder2'));
+        $this->assertTrue(File::exists($dir . '/folder2/samplefile-in-folder2.txt'));
+        $this->assertEquals(1, count(File::allFiles($dir . '/folder2')));
+        $this->assertFalse(File::exists($dir . '/node_modules'));
+        $this->assertFalse(File::exists($dir . '/__MACOSX'));
+        $this->assertFalse(File::exists($dir . '/release-1.2'));
+        $this->assertFalse(File::exists($dir . '/release-1.2.zip'));
     }
 
     /** @test */

tests/SourceRepositoryTypes/GithubRepositoryTypeTest.php

@@ -16,6 +16,12 @@
 
 class GithubRepositoryTypeTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->resetDownloadDir();
+    }
+
     /** @test */
     public function it_can_instantiate(): void
     {
@@ -55,7 +61,7 @@ public function it_can_run_update(): void
 
         /** @var Release $release */
         $release = resolve(Release::class);
-        $release->setStoragePath('/tmp')
+        $release->setStoragePath((string) config('self-update.repository_types.github.download_path'))
                 ->setVersion('1.0')
                 ->setRelease('release-1.0.zip')
                 ->updateStoragePath()

tests/SourceRepositoryTypes/HttpRepositoryTypeTest.php

@@ -10,6 +10,12 @@
 
 class HttpRepositoryTypeTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->resetDownloadDir();
+    }
+
     /** @test */
     public function it_can_instantiate(): void
     {
@@ -23,7 +29,7 @@ public function it_can_run_update(): void
         $http = resolve(HttpRepositoryType::class);
 
         $release = resolve(Release::class);
-        $release->setStoragePath('/tmp')
+        $release->setStoragePath((string) config('self-update.repository_types.http.download_path'))
                 ->setRelease('release-1.0.zip')
                 ->updateStoragePath()
                 ->setDownloadUrl('some-local-file')
@@ -161,7 +167,7 @@ public function it_cannot_get_new_version_available_and_fails_with_exception():
     {
         $this->expectException(InvalidArgumentException::class);
 
-        /** @var HttpRepositoryType $github */
+        /** @var HttpRepositoryType $http */
         $http = resolve(HttpRepositoryType::class);
         $http->isNewVersionAvailable('');
     }

tests/TestCase.php

@@ -56,7 +56,7 @@ protected function getEnvironmentSetUp($app)
                     'type' => 'http',
                     'repository_url' => 'https://github.com/invoiceninja/invoiceninja/releases',
                     'pkg_filename_format' => env('SELF_UPDATER_PKG_FILENAME_FORMAT', 'v_VERSION_'),
-                    'download_path' => env('SELF_UPDATER_DOWNLOAD_PATH', '/tmp'),
+                    'download_path' => self::DOWNLOAD_PATH,
                     'private_access_token' => '',
                 ],
             ],