Reset download directory after each test

Author: Holger Lösken

tests/Commands/CheckUpdateTest.php

@@ -10,6 +10,12 @@
 
 final class CheckUpdateTest extends TestCase
 {
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->resetDownloadDir();
+    }
+
     /** @test */
     public function it_can_run_check_update_command_without_new_version_available(): void
     {

tests/Models/ReleaseTest.php

@@ -24,6 +24,8 @@ protected function setUp(): void
         parent::setUp();
         $this->release = resolve( Release::class );
         $this->vfs = vfsStream::setup();
+
+        $this->resetDownloadDir();
     }
 
     /** @test */
@@ -132,7 +134,7 @@ public function it_cannot_extract_zip_and_fails_with_exception(): void
     /** @test */
     public function it_can_extract_zip_to_storage_path(): void
     {
-        $this->release->setStoragePath('/tmp')->setRelease('release-test-1.2.zip')->updateStoragePath();
+        $this->release->setStoragePath((string) config('self-update.repository_types.github.download_path'))->setRelease('release-test-1.2.zip')->updateStoragePath();
 
         $zip = new \ZipArchive();
         $res = $zip->open($this->release->getStoragePath(), \ZipArchive::CREATE);
@@ -167,7 +169,7 @@ public function it_can_download(): void
         ]);
 
         $this->release->setDownloadUrl('url-to-download')
-                      ->setStoragePath('/tmp')
+                      ->setStoragePath((string) config('self-update.repository_types.github.download_path'))
                       ->setRelease('release-1.0.zip')
                       ->updateStoragePath();
 

tests/Models/UpdateExecutorTest.php

@@ -26,22 +26,25 @@ protected function setUp(): void
         $this->release = resolve(Release::class);
 
         $this->vfs = vfsStream::setup('root');
+
+        $this->resetDownloadDir();
     }
 
     /** @test */
     public function it_can_run_successfully(): void
     {
-        File::makeDirectory('/tmp/update-dir', 0775, false, true);
+        $dir = (string) config('self-update.repository_types.github.download_path') . '/update-dir';
+        File::makeDirectory($dir, 0775, false, true);
 
-        $this->release->setStoragePath('/tmp')
+        $this->release->setStoragePath((string) config('self-update.repository_types.github.download_path'))
                       ->setRelease('release-1.0.zip')
                       ->updateStoragePath()
                       ->setDownloadUrl('some-local-file')
                       ->download($this->getMockedDownloadZipFileClient());
         $this->release->extract();
 
         $updateExecutor = new UpdateExecutor();
-        $this->assertTrue($updateExecutor->setBasePath('/tmp/update-dir')->run($this->release));
+        $this->assertTrue($updateExecutor->setBasePath($dir)->run($this->release));
 
     }
 

tests/TestCase.php

@@ -7,19 +7,20 @@
 use Codedge\Updater\SourceRepositoryTypes\GithubRepositoryTypes\GithubBranchType;
 use Codedge\Updater\SourceRepositoryTypes\GithubRepositoryTypes\GithubTagType;
 use Codedge\Updater\SourceRepositoryTypes\HttpRepositoryType;
-use Codedge\Updater\Tests\Commands\SamplePostUpdate;
-use Codedge\Updater\Tests\Commands\SamplePreUpdate;
 use Codedge\Updater\UpdaterFacade;
 use Codedge\Updater\UpdaterServiceProvider;
 use GuzzleHttp\Client;
 use GuzzleHttp\Handler\MockHandler;
 use GuzzleHttp\HandlerStack;
 use GuzzleHttp\Psr7\Response;
+use Illuminate\Filesystem\Filesystem;
 use Illuminate\Foundation\Application;
 use Orchestra\Testbench\TestCase as Orchestra;
 
 abstract class TestCase extends Orchestra
 {
+    const DOWNLOAD_PATH = '/tmp/self-updater';
+
     /**
      * @var array
      */
@@ -47,7 +48,7 @@ protected function getEnvironmentSetUp($app)
                     'repository_vendor' => 'laravel',
                     'repository_name' => 'laravel',
                     'repository_url' => '',
-                    'download_path' => '/tmp',
+                    'download_path' => self::DOWNLOAD_PATH,
                     'private_access_token' => '',
                     'use_branch' => '',
                 ],
@@ -104,7 +105,6 @@ protected function getEnvironmentSetUp($app)
                 $app->make(UpdateExecutor::class)
             );
         });
-
     }
 
     protected function getMockedClient($responses): Client
@@ -147,6 +147,19 @@ protected function getResponseEmpty(): Response
         );
     }
 
+    protected function resetDownloadDir()
+    {
+        /** @var Filesystem $filesystem */
+        $filesystem = $this->app->make(Filesystem::class);
+
+        if($filesystem->exists(self::DOWNLOAD_PATH)) {
+            $filesystem->deleteDirectory(self::DOWNLOAD_PATH);
+            $filesystem->makeDirectory(self::DOWNLOAD_PATH);
+        } else {
+            $filesystem->makeDirectory(self::DOWNLOAD_PATH);
+        }
+    }
+
     /**
      * @param Application $app
      * @return array