Better readme example, make update function fit to contract

Author: Holger Lösken

README.md

@@ -121,13 +121,16 @@ Route::get('/', function (\Codedge\Updater\UpdaterManager $updater) {
     if($updater->source()->isNewVersionAvailable()) {
 
         // Get the current installed version
-        $updater->source()->getVersionInstalled();
+        echo $updater->source()->getVersionInstalled();
 
         // Get the new version available
-        $updater->source()->getVersionAvailable();
+        $versionAvailable = $updater->source()->getVersionAvailable();
+
+        // Create a release
+        $release = $updater->source()->fetch($versionAvailable);
 
         // Run the update process
-        $updater->source()->update();
+        $updater->source()->update($release);
 
     } else {
         echo "No new version available.";

src/SourceRepository.php

@@ -4,6 +4,7 @@
 
 use Codedge\Updater\Contracts\SourceRepositoryTypeContract;
 use Codedge\Updater\Models\Release;
+use Codedge\Updater\Models\UpdateExecutor;
 use Codedge\Updater\Traits\SupportPrivateAccessToken;
 use Codedge\Updater\Traits\UseVersionFile;
 use Illuminate\Support\Facades\Artisan;
@@ -23,14 +24,20 @@ final class SourceRepository implements SourceRepositoryTypeContract
      */
     protected $sourceRepository;
 
+    /**
+     * @var UpdateExecutor
+     */
+    protected $updateExecutor;
+
     /**
      * SourceRepository constructor.
      *
      * @param SourceRepositoryTypeContract $sourceRepository
      */
-    public function __construct(SourceRepositoryTypeContract $sourceRepository)
+    public function __construct(SourceRepositoryTypeContract $sourceRepository, UpdateExecutor $updateExecutor)
     {
         $this->sourceRepository = $sourceRepository;
+        $this->updateExecutor = $updateExecutor;
     }
 
     /**
@@ -48,21 +55,14 @@ public function fetch($version = ''): Release
     }
 
     /**
-     * Perform the actual update process.
+     * @param Release $release
      *
-     * @param string $version       Define the version you want to update to
      * @return bool
+     * @throws \Exception
      */
-    public function update($version = ''): bool
+    public function update(Release $release): bool
     {
-        $version = $version ?: $this->getVersionAvailable();
-        $release = $this->fetch($version);
-
-        $this->preUpdateArtisanCommands();
-        $updateStatus = $this->sourceRepository->update($release);
-        $this->postUpdateArtisanCommands();
-
-        return $updateStatus;
+        return $this->updateExecutor->run($release);
     }
 
     /**

src/SourceRepositoryTypes/GithubRepositoryType.php

@@ -79,7 +79,7 @@ public function update(Release $release): bool
 
     protected function useBranchForVersions(): bool
     {
-        return $this->config['use_branch'] !== '';
+        return !empty($this->config['use_branch']);
     }
 
     /**

src/UpdaterManager.php

@@ -6,6 +6,7 @@
 
 use Codedge\Updater\Contracts\SourceRepositoryTypeContract;
 use Codedge\Updater\Contracts\UpdaterContract;
+use Codedge\Updater\Models\UpdateExecutor;
 use Codedge\Updater\SourceRepositoryTypes\GithubRepositoryType;
 use Codedge\Updater\SourceRepositoryTypes\HttpRepositoryType;
 use Exception;
@@ -78,7 +79,7 @@ public function getDefaultSourceRepository()
      */
     public function sourceRepository(SourceRepositoryTypeContract $sourceRepository): SourceRepositoryTypeContract
     {
-        return new SourceRepository($sourceRepository);
+        return new SourceRepository($sourceRepository, $this->app->make(UpdateExecutor::class));
     }
 
     /**