Improve testing

Author: Holger Lösken

config/self-update.php

@@ -60,7 +60,7 @@
     | Exclude folders from update
     |--------------------------------------------------------------------------
     |
-    | Specifiy folders which should not be updated and will be skipped during the
+    | Specific folders which should not be updated and will be skipped during the
     | update process.
     |
     | Here's already a list of good examples to skip. You may want to keep those.
@@ -114,13 +114,13 @@
 
         'mail' => [
             'to' => [
-                'address' => env('SELF_UPDATER_MAILTO_ADDRESS', ''),
+                'address' => env('SELF_UPDATER_MAILTO_ADDRESS', '[email protected]'),
                 'name' => env('SELF_UPDATER_MAILTO_NAME', ''),
             ],
 
             'from' => [
-                'address' => env('SELF_UPDATER_MAIL_FROM_ADDRESS', ''),
-                'name' => env('SELF_UPDATER_MAIL_FROM_NAME', ''),
+                'address' => env('SELF_UPDATER_MAIL_FROM_ADDRESS', '[email protected]'),
+                'name' => env('SELF_UPDATER_MAIL_FROM_NAME', 'Update'),
             ],
         ]
     ],

src/Events/UpdateSucceeded.php

@@ -6,13 +6,11 @@
 
 class UpdateSucceeded
 {
-    protected $release;
-
     /**
-     * UpdateFailed constructor.
-     *
-     * @param Release $release
+     * @var Release
      */
+    protected $release;
+
     public function __construct(Release $release)
     {
         $this->release = $release;

src/Models/UpdateExecutor.php

@@ -66,6 +66,7 @@ public function run(Release $release): bool
 
             // Delete the version file
             $this->deleteVersionFile();
+
             event(new UpdateSucceeded($release));
 
             return true;

tests/Notifications/EventHandlerTest.php

@@ -0,0 +1,63 @@
+<?php declare(strict_types=1);
+
+namespace Codedge\Updater\Tests\Notifications;
+
+
+use Codedge\Updater\Events\UpdateFailed;
+use Codedge\Updater\Models\Release;
+use Codedge\Updater\Notifications\Notifiable;
+use Codedge\Updater\Notifications\Notifications\UpdateFailed as UpdateFailedNotification;
+use Codedge\Updater\Tests\TestCase;
+use Illuminate\Support\Facades\Notification;
+
+class EventHandlerTest extends TestCase
+{
+    public function setUp(): void
+    {
+        parent::setUp();
+
+        Notification::fake();
+    }
+
+    /** @test */
+    public function it_will_send_a_notification_by_default_when_update_failed()
+    {
+        $this->fireUpdateFailedEvent();
+
+        Notification::assertSentTo(new Notifiable(), UpdateFailedNotification::class);
+    }
+
+    /**
+     * @test
+     *
+     * @dataProvider channelProvider
+     *
+     * @param array $expectedChannels
+     */
+    public function it_will_send_a_notification_via_the_configured_notification_channels(array $expectedChannels)
+    {
+        config()->set('self-update.notifications.notifications.'.UpdateFailedNotification::class, $expectedChannels);
+
+        $this->fireUpdateFailedEvent();
+
+        Notification::assertSentTo(new Notifiable(), UpdateFailedNotification::class, function ($notification, $usedChannels) use ($expectedChannels) {
+            return $expectedChannels == $usedChannels;
+        });
+    }
+
+    public function channelProvider()
+    {
+        return [
+            [[]],
+            [['mail']],
+        ];
+    }
+
+    protected function fireUpdateFailedEvent()
+    {
+        $release = resolve(Release::class);
+
+        event(new UpdateFailed($release));
+    }
+
+}