Merge pull request #190 from turbo124/master

Improve performance of permission checking

Author: codedge

src/Models/UpdateExecutor.php

@@ -52,7 +52,7 @@ public function setBasePath(string $path): self
      */
     public function run(Release $release): bool
     {
-        if (checkPermissions((new Finder())->in($this->basePath))) {
+        if (checkPermissions($this->basePath)) {
             $releaseFolder = createFolderFromFile($release->getStoragePath());
 
             // Move all directories first

src/helpers.php

@@ -28,17 +28,19 @@ function dirsIntersect(array $directory, array $excludedDirs): bool
      *
      * @return bool
      */
-    function checkPermissions(Finder $directory): bool
+    function checkPermissions(string $directory): bool
     {
-        $checkPermission = true;
+        $directoryIterator = new \RecursiveDirectoryIterator($directory);
 
-        collect($directory->getIterator())->each(function (SplFileInfo $file) use (&$checkPermission) {
-            if ($file->isWritable() === false) {
-                $checkPermission = false;
+        foreach(new \RecursiveIteratorIterator($directoryIterator) as $file) {
+
+            if($file->isFile() && !$file->isWritable()){
+                return false;
             }
-        });
 
-        return $checkPermission;
+        }
+
+        return true;
     }
 }