tests reorg, docstring

Author: tkucar

src/codegen/sdk/core/expressions/name.py

@@ -51,35 +51,61 @@ def rename_if_matching(self, old: str, new: str):
             self.edit(new)
 
 
-    def _resolve_conditionals(self,conditional_parent:ConditionalBlock,name:str,original_resolved):
+    @noapidoc
+    def _resolve_conditionals(self, conditional_parent: ConditionalBlock, name: str, original_resolved):
+        """Resolves name references within conditional blocks by traversing the conditional chain.
+
+        This method handles name resolution within conditional blocks (like if/elif/else statements) by:
+        1. Finding the appropriate search boundary based on the conditional block's position
+        2. Handling "fake" conditionals by traversing up the conditional chain
+        3. Yielding resolved names while respecting conditional block boundaries
+
+        Args:
+            conditional_parent (ConditionalBlock): The parent conditional block containing the name reference
+            name (str): The name being resolved
+            original_resolved: The originally resolved symbol that triggered this resolution
+
+        Yields:
+            Symbol | Import | WildcardImport: Resolved symbols found within the conditional blocks
+
+        Notes:
+            - A "fake" conditional is one where is_true_conditional() returns False
+            - The search_limit ensures we don't resolve names that appear after our target
+            - The method stops when it either:
+                a) Reaches the top of the conditional chain
+                b) Returns to the original conditional block
+                c) Can't find any more resolutions
+        """
         search_limit = conditional_parent.start_byte_for_condition_block
-        if search_limit>=original_resolved.start_byte:
-            search_limit=original_resolved.start_byte-1
+        if search_limit >= original_resolved.start_byte:
+            search_limit = original_resolved.start_byte-1
         if not conditional_parent.is_true_conditional(original_resolved):
             #If it's a fake conditional we must skip any potential enveloping conditionals
             def get_top_of_fake_chain(conditional,resolved,search_limit=0):
-                if skip_fake:= conditional.parent_of_type(ConditionalBlock):
+                if skip_fake := conditional.parent_of_type(ConditionalBlock):
                     if skip_fake.is_true_conditional(resolved):
                         return skip_fake.start_byte_for_condition_block
                     search_limit=skip_fake.start_byte_for_condition_block
                     return get_top_of_fake_chain(skip_fake,conditional,search_limit)
                 return search_limit
-            if search_limit:=get_top_of_fake_chain(conditional_parent,original_resolved):
-                search_limit=search_limit
+            if search_limit := get_top_of_fake_chain(conditional_parent,original_resolved):
+                search_limit = search_limit
             else:
                 return
 
         original_conditional = conditional_parent
-        while next_resolved:= next(conditional_parent.resolve_name(name,start_byte=search_limit,strict=False),None):
+        while next_resolved := next(conditional_parent.resolve_name(name,start_byte=search_limit,strict=False),None):
             yield next_resolved
             next_conditional = next_resolved.parent_of_type(ConditionalBlock)
             if not next_conditional or  next_conditional == original_conditional:
                 return
             search_limit = next_conditional.start_byte_for_condition_block
             if next_conditional and not next_conditional.is_true_conditional(original_resolved):
                 pass
-            if search_limit>=next_resolved.start_byte:
-                search_limit=next_resolved.start_byte-1
+            if search_limit >= next_resolved.start_byte:
+                search_limit = next_resolved.start_byte - 1
+
+
     @noapidoc
     @reader
     def resolve_name(self, name: str, start_byte: int | None = None, strict: bool = True) -> Generator["Symbol | Import | WildcardImport"]:

src/codegen/sdk/core/interfaces/conditional_block.py

@@ -6,7 +6,9 @@
 
 
 class ConditionalBlock(Statement, ABC):
-    """An interface for any code block that might not be executed in the code, e.g if block/else block/try block/catch block ect."""
+    """An interface for any code block that might not be executed in the code,
+    e.g if block/else block, try block/catch block ect.
+    """
 
     @property
     @abstractmethod
@@ -25,5 +27,8 @@ def start_byte_for_condition_block(self) -> int:
 
     @noapidoc
     def is_true_conditional(self,descendant) -> bool:
-        """Returns if this conditional is truly conditional, this is necessary as an override for things like finally statements that share a parent with try blocks"""
+        """Returns if this conditional is truly conditional,
+        this is necessary as an override for things like finally
+        statements that share a parent with try blocks
+        """
         return True

src/codegen/sdk/core/interfaces/editable.py

@@ -1107,6 +1107,7 @@ def parent_of_types(self, types: set[type[T]]) -> T | None:
         return None
 
     def is_child_of(self, instance: Editable) -> bool:
+        """Checks if this node is a descendant of the given editable instance in the AST."""
         if not self.parent:
             return False
         if self.parent is instance: