fix: empty collection remove

src/codegen/sdk/core/symbol_groups/collection.py

@@ -19,7 +19,7 @@
 Parent = TypeVar("Parent")
 
 
 class Collection(SymbolGroup[Child, Parent], MutableSequence[Child], Generic[Child, Parent]):
     """Ordered collection of nodes
     Attributes:
         _bracket_size: Number of characters wrapping the collection
@@ -47,7 +47,7 @@
         if children is not None:
             self._init_children(children)
 
     def _init_children(self, symbols: list[Child]):
         """Call this after setting self._symbols."""
         if self.ts_node.start_point[0] != self.ts_node.end_point[0] and symbols:
             # This is a multiline collection.
@@ -70,7 +70,7 @@
         if isinstance(key, slice):
             assert isinstance(value, Iterable)
             for idx, item in zip(range(key.start, key.stop, key.step), value):
                 self[idx] = item
         else:
             assert not isinstance(value, Iterable)
             if isinstance(value, Editable):
@@ -94,7 +94,7 @@
         return self._elements + self._inserts_till()
 
     @writer
     def remove(self, value: Child | None = None, *args, **kwargs) -> None:
         """Removes an element from a Collection.
 
         Deletes the specified element from the Collection by calling its remove method. If no value is specified,
@@ -112,6 +112,7 @@
         # For example, let's remove all occurrences of the value instead of just the first one
         if value is None:
             super().remove(*args, **kwargs)
+            Editable.remove(self, *args, **kwargs)
         else:
             value.remove(*args, **kwargs)
 
@@ -241,7 +242,7 @@
         Returns:
             None
         """
         return Editable.edit(self, *args, **kwargs)  # HACK: keep start/end brackets
 
     @property
     @reader
@@ -277,4 +278,4 @@
         self._reversed.clear()
 
     def _smart_remove(self, child, *args, **kwargs) -> bool:
         return self.parent._smart_remove(self, child, *args, **kwargs)

tests/unit/codegen/sdk/typescript/expressions/ternary_expression/test_ternary_reduce_condition.py

@@ -266,3 +266,32 @@ def test_reduce_ternary_condition_with_dict_trailing_comma(tmpdir):
 }
 """
     )
+
+
+def test_reduce_ternary_condition_with_empty_arrays(tmpdir):
+    # language=typescript
+    content = """
+function foo(): string[] {
+    let result = condition ? [] : ['value'];
+    let result2 = condition ? ['value'] : [];
+    return result.concat(result2);
+}
+"""
+    with get_codebase_session(tmpdir=tmpdir, files={"dir/file1.ts": content}, programming_language=ProgrammingLanguage.TYPESCRIPT) as codebase:
+        file: TSFile = codebase.get_file("dir/file1.ts")
+        foo = file.get_function("foo")
+        ternary1 = foo.code_block.statements[0].value
+        ternary2 = foo.code_block.statements[1].value
+        ternary1.reduce_condition(True)
+        ternary2.reduce_condition(False)
+    # language=typescript
+    assert (
+        file.content
+        == """
+function foo(): string[] {
+    let result = [];
+    let result2 = [];
+    return result.concat(result2);
+}
+"""
+    )