[CG-8871] fix: removing dead code removes code that should stay #355
Conversation
|
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files |
| Returns: | ||
| None | ||
| """ | ||
| if getattr(self.parent, "assignments", None) and len(self.parent.assignments) > 1: |
There was a problem hiding this comment.
Can we do isinstance here?
| @@ -96,3 +99,70 @@ def inline_comment(self) -> PyCommentGroup | None: | |||
| """ | |||
| # HACK: This is a temporary solution until comments are fixed | |||
| return PyCommentGroup.from_symbol_inline_comments(self, self.ts_node.parent) | |||
|
|
|||
| @remover | |||
| def remove(self, delete_formatting: bool = True, priority: int = 0, dedupe: bool = True) -> None: | |||
There was a problem hiding this comment.
Maybe it'll be better to implement _smart_remove rather than overwriting remove?
There was a problem hiding this comment.
I need to know what Assignment it's being called on and remove dissolves it into Value which does not preserve the distinction, if there is a better idea than override let me know
| @reader | ||
| @noapidoc | ||
| @override | ||
| def _resolved_types(self) -> Generator[ResolutionStack[Self], None, None]: |
There was a problem hiding this comment.
I don't think this is the right approach. It will create duplicated edges. For example
def foo():
...
def bar():
...from filea import *
foo() # will be a usage of foo and barFor some context, we regular imports are resolved as follows.
- We add the import to valid_import_names
- When resolving, we check valid_symbol_names for the name
- We call _resolved_types on the import
Since it's impossible to know which symbol you're importing in a wildcard, wildcards follow the following pattern
- We check the imported file and get all valid_import_names (this is the same as valid_symbol_names in python) from that file
- For each imported symbol, we created a wilcardImport for that name and put it in the valid imports
- When resolving, we call _resolved_types on the wildcard import. We create an edge through the import but we point it at the specific imported symbol.
For example, in the above case, we'd call _resolved_types on the wildcard for foo. But it'll create edges from the import to foo and from the call site to foo
There was a problem hiding this comment.
It seemed to work as expected, I ve added additional UTs, have I missed anything?
Motivation
Content
Testing
Please check the following before marking your PR as ready for review