Skip to content

chore: disable failing parse tests for now #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

chore: disable failing parse tests for now #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cba5fa1
chore: disable failing parse tests for now
christinewangcw Feb 7, 2025
bd9adf6
Merge branch 'develop' into chore-disable-failing-oss-tets
christinewangcw Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions tests/integration/codemod/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,6 @@
size = list(map(Size, metafunc.config.getoption("--size")))

match metafunc.definition.name:
# case "test_codemods_diffs":
# cases = []
# for case in find_codemod_test_cases(repos):
# cases.append(case)

# metafunc.parametrize(
# "raw_codemod,repo,expected",
# [pytest.param(i.codemod_metadata.codemod, i.repo, i.test_dir, marks=pytest.mark.xdist_group(i.repo.name)) for i in cases],
# indirect=["repo", "expected"],
# ids=[f"{i.codemod_metadata.name}-{i.repo.name}" for i in cases],
# scope="session",
# )
case "test_codemods_cloned_repos":
cases = []
for case in find_codemod_test_cases(repos):
Expand All @@ -92,7 +80,8 @@
scope="session",
)
case "test_codemods_parse":
to_test = {name: repo for name, repo in repos.items()}
excluded_repos = {"typeshed", "plone", "papermark", "vscode"} # TODO(CG-10655): fix these reps
to_test = {name: repo for name, repo in repos.items() if name not in excluded_repos}
metafunc.parametrize(
"repo",
[pytest.param(repo, marks=pytest.mark.xdist_group(repo.name)) for repo in to_test.values()],
Expand Down Expand Up @@ -220,6 +209,6 @@
# Ensure the execute method is added to the codemod
assert hasattr(codemod, "execute"), "codemod has no execute method"
yield codemod
if ONLY_STORE_CHANGED_DIFFS and diff_path.exists() and diff_path.read_text().strip() == codemod_metadata.diff.strip():

Check failure on line 212 in tests/integration/codemod/conftest.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Item "None" of "str | None" has no attribute "strip"  [union-attr]
logger.info(f"Removing diff {diff_path}")
diff_path.unlink()
Loading