Skip to content

Fix OSS Parse Tests #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 10, 2025
Merged

Fix OSS Parse Tests #372

merged 11 commits into from
Feb 10, 2025

Conversation

EdwardJXLi
Copy link
Contributor

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed

@EdwardJXLi EdwardJXLi requested review from codegen-team and a team as code owners February 8, 2025 02:52
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...codegen/sdk/core/detached_symbols/function_call.py 94.11% 1 Missing ⚠️
.../codegen/sdk/core/expressions/chained_attribute.py 66.66% 1 Missing ⚠️
src/codegen/sdk/typescript/ts_config.py 75.00% 1 Missing ⚠️
Additional details and impacted files

@EdwardJXLi EdwardJXLi added the parse-tests Enable parse tests for this PR label Feb 9, 2025
@EdwardJXLi EdwardJXLi merged commit 3b3a393 into develop Feb 10, 2025
21 of 24 checks passed
@EdwardJXLi EdwardJXLi deleted the eli-cg-10655-fix-oss-parse-tests branch February 10, 2025 19:52
tawsifkamal pushed a commit that referenced this pull request Feb 10, 2025
# Motivation

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->

# Testing

<!-- How was the change tested? -->

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

tkfoss pushed a commit that referenced this pull request Feb 10, 2025
# Motivation

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->

# Testing

<!-- How was the change tested? -->

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parse-tests Enable parse tests for this PR released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants