Skip to content

Remove LFS from codegen-sdk (+ disable disallowed-words check) #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .gitattributes

This file was deleted.

3 changes: 0 additions & 3 deletions .github/disallowed-words.txt

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- run: uv run --frozen pre-commit run --show-diff-on-failure --color=always --all-files --source ${{ github.event.pull_request.base.sha || github.event.before }} --origin ${{ github.event.pull_request.head.sha || github.event.after }}
shell: bash
env:
SKIP: disallowed-words-check,circleci_validate
SKIP: circleci_validate

- uses: stefanzweifel/git-auto-commit-action@v5
# Always commit changes even if pre-commit failed
Expand Down
2 changes: 0 additions & 2 deletions .lfsconfig

This file was deleted.

11 changes: 6 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,12 @@ repos:

- repo: "local"
hooks:
- id: disallowed-words-check
name: Check for disallowed words
entry: scripts/disallowed-words-check.sh
language: script
files: '' # Check all files
# Disabled as part of LFS removal.
# - id: disallowed-words-check
# name: Check for disallowed words
# entry: scripts/disallowed-words-check.sh
# language: script
# files: '' # Check all files
- id: generate-runner-imports
name: Generate Runner Imports
entry: bash -c "uv run --frozen python -m codegen.gscli.cli generate runner-imports src/codegen/shared/compilation/function_imports.py"
Expand Down
8 changes: 4 additions & 4 deletions scripts/install-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@ if command -v sudo &> /dev/null; then
fi

if command -v apt &> /dev/null; then
$SUDO apt update && $SUDO apt install -y git-lfs jq \
$SUDO apt update && $SUDO apt install -y jq \
libpixman-1-dev \
libcairo2-dev \
libpango1.0-dev \
libjpeg-dev \
libgif-dev \
librsvg2-dev
elif command -v brew &> /dev/null; then
brew install git-lfs jq
brew install jq
elif command -v dnf &> /dev/null; then
$SUDO dnf install -y git-lfs jq
$SUDO dnf install -y jq
else
echo "Error: Could not find package manager to install git-lfs and jq"
echo "Error: Could not find package manager to install jq"
exit 1
fi
5 changes: 0 additions & 5 deletions scripts/setup-lfs.sh

This file was deleted.

1 change: 0 additions & 1 deletion scripts/setup.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env bash
./scripts/setup-lfs.sh
uv tool install pre-commit --with pre-commit-uv
uv tool install deptry
uv tool update-shell
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/1.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/2.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/3.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/4.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/5.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/6.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/7.json

This file was deleted.

3 changes: 0 additions & 3 deletions tests/integration/codemod/repos/extra/8.json

This file was deleted.

4 changes: 1 addition & 3 deletions tests/integration/codemod/repos/repos.json
Git LFS file not shown

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading