Pujol cg 10460 make codebasefetch codebase work on the sdk #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayhack
approved these changes
Jan 24, 2025
…e-work-on-the-sdk
kopekC
deleted the
pujol-cg-10460-make-codebasefetch_codebase-work-on-the-sdk
branch
jayhack
reviewed
Jan 24, 2025
| @@ -82,6 +82,49 @@ def create_from_commit(cls, repo_path: str, default_branch: str, commit: str, ur | |||
| op.checkout_commit(commit) | |||
| return op | |||
|
|
|||
| @classmethod | |||
| def create_from_repo(cls, repo_path: str, url: str) -> Self: | |||
There was a problem hiding this comment.
Why does this not take in a commit?
jayhack
pushed a commit
that referenced
this pull request
Feb 9, 2025
# Motivation Allows us to fetch remote codebases - [ x] I have added tests for my changes - [ x] I have updated the documentation or added new documentation as needed - [x ] I have read and agree to the [Contributor License Agreement](../CLA.md) --------- Co-authored-by: KopekC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allows us to fetch remote codebases