Miscellaneous linting & cleanups #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not thrown by any of our implementations. I could only find one usage on github, in the SibillaMavenPlugin, last touched in 2010.
|
PR has conflicts by now |
Not too surprising after 2 years! I'm happy to remake it, if you're happy to review |
|
I'm not surprised either. If you can provide a PR in a couple of hours, that would be great. I'd like to push a new release after that. |
I managed a few of the safer-looking ones at least. See what you think: |
|
superseded by #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the IntelliJ IDEA linter in Java 7 mode and did some of the things it suggested.
Is this palatable?