@@ -69,25 +69,27 @@ private function createRequest(): IncomingRequest
69
69
return $ request ;
70
70
}
71
71
72
+ /**
73
+ * @doesNotPerformAssertions
74
+ */
72
75
public function testBeforeDoNothingWhenCLIRequest ()
73
76
{
74
77
$ cliRequest = new CLIRequest (new MockAppConfig ());
75
78
76
- $ ret = $ this ->invalidChars ->before ($ cliRequest );
77
-
78
- $ this ->assertNull ($ ret );
79
+ $ this ->invalidChars ->before ($ cliRequest );
79
80
}
80
81
82
+ /**
83
+ * @doesNotPerformAssertions
84
+ */
81
85
public function testBeforeValidString ()
82
86
{
83
87
$ _POST ['val ' ] = [
84
88
'valid string ' ,
85
89
];
86
90
$ _COOKIE ['val ' ] = 'valid string ' ;
87
91
88
- $ ret = $ this ->invalidChars ->before ($ this ->request );
89
-
90
- $ this ->assertNull ($ ret );
92
+ $ this ->invalidChars ->before ($ this ->request );
91
93
}
92
94
93
95
public function testBeforeInvalidUTF8StringCausesException ()
@@ -104,7 +106,7 @@ public function testBeforeInvalidUTF8StringCausesException()
104
106
$ this ->invalidChars ->before ($ this ->request );
105
107
}
106
108
107
- public function testBeforeInvalidControllCharCausesException ()
109
+ public function testBeforeInvalidControlCharCausesException ()
108
110
{
109
111
$ this ->expectException (SecurityException::class);
110
112
$ this ->expectExceptionMessage ('Invalid Control characters in cookie: ' );
@@ -116,6 +118,8 @@ public function testBeforeInvalidControllCharCausesException()
116
118
}
117
119
118
120
/**
121
+ * @doesNotPerformAssertions
122
+ *
119
123
* @dataProvider stringWithLineBreakAndTabProvider
120
124
*
121
125
* @param string $input
@@ -124,9 +128,7 @@ public function testCheckControlStringWithLineBreakAndTabReturnsTheString($input
124
128
{
125
129
$ _GET ['val ' ] = $ input ;
126
130
127
- $ ret = $ this ->invalidChars ->before ($ this ->request );
128
-
129
- $ this ->assertNull ($ ret );
131
+ $ this ->invalidChars ->before ($ this ->request );
130
132
}
131
133
132
134
public function stringWithLineBreakAndTabProvider ()
@@ -152,9 +154,7 @@ public function testCheckControlStringWithControlCharsCausesException($input)
152
154
153
155
$ _GET ['val ' ] = $ input ;
154
156
155
- $ ret = $ this ->invalidChars ->before ($ this ->request );
156
-
157
- $ this ->assertNull ($ ret );
157
+ $ this ->invalidChars ->before ($ this ->request );
158
158
}
159
159
160
160
public function stringWithControlCharsProvider ()
0 commit comments