Skip to content

Commit 0cee5b9

Browse files
committed
Fix nullCoalesce.variable errors.
rm nullCoalesce.variable.neon Update error count Restore missing nullCoalesce.variable.neon file Update loader.neon and remove obsolete nullCoalesce.variable.neon Use type checking instead of null coalescing Prevent superglobals from being changed by users
1 parent 50b3f57 commit 0cee5b9

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

system/HTTP/RedirectResponse.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ public function withInput()
9393
{
9494
$session = service('session');
9595
$session->setFlashdata('_ci_old_input', [
96-
'get' => $_GET ?? [],
97-
'post' => $_POST ?? [],
96+
'get' => isset($_GET) ? $_GET : [],
97+
'post' => isset($_POST) ? $_POST : [],
9898
]);
9999

100100
$this->withErrors();

utils/phpstan-baseline/loader.neon

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# total 3575 errors
1+
# total 3573 errors
22
includes:
33
- argument.type.neon
44
- assign.propertyType.neon
@@ -23,7 +23,6 @@ includes:
2323
- missingType.return.neon
2424
- notIdentical.alwaysTrue.neon
2525
- nullCoalesce.property.neon
26-
- nullCoalesce.variable.neon
2726
- offsetAccess.notFound.neon
2827
- property.defaultValue.neon
2928
- property.nonObject.neon

utils/phpstan-baseline/nullCoalesce.variable.neon

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)