refactor: fix property.protected errors (#9517)

Author: paulbalandan

system/Encryption/Encryption.php

@@ -23,6 +23,11 @@
  * This class determines the driver, cipher, and mode to use, and then
  * initializes the appropriate encryption handler.
  *
+ * @property-read string       $digest
+ * @property-read string       $driver
+ * @property-read list<string> $drivers
+ * @property-read string       $key
+ *
  * @see \CodeIgniter\Encryption\EncryptionTest
  */
 class Encryption

system/I18n/TimeDifference.php

@@ -17,7 +17,13 @@
 use IntlCalendar;
 
 /**
- * Class TimeDifference
+ * @property-read float|int $days
+ * @property-read float|int $hours
+ * @property-read float|int $minutes
+ * @property-read float|int $months
+ * @property-read int       $seconds
+ * @property-read float|int $weeks
+ * @property-read float|int $years
  *
  * @see \CodeIgniter\I18n\TimeDifferenceTest
  */

utils/phpstan-baseline/isset.property.neon

@@ -1,4 +1,4 @@
-# total 3 errors
+# total 2 errors
 
 parameters:
     ignoreErrors:
@@ -11,8 +11,3 @@ parameters:
             message: '#^Static property CodeIgniter\\Email\\Email\:\:\$func_overload \(bool\) in isset\(\) is not nullable\.$#'
             count: 1
             path: ../../system/Email/Email.php
-
-        -
-            message: '#^Property CodeIgniter\\I18n\\TimeDifference\:\:\$days \(int\) in isset\(\) is not nullable\.$#'
-            count: 1
-            path: ../../tests/system/I18n/TimeDifferenceTest.php

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 3605 errors
+# total 3589 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
@@ -31,7 +31,6 @@ includes:
     - property.nonObject.neon
     - property.notFound.neon
     - property.phpDocType.neon
-    - property.protected.neon
     - property.readOnlyByPhpDocAssignOutOfClass.neon
     - property.readOnlyByPhpDocDefaultValue.neon
     - staticMethod.notFound.neon