Update Oracle Forge::_updateBatch()

Author: sclubricants

system/Database/OCI8/Builder.php

@@ -233,46 +233,81 @@ protected function resetSelect()
      */
     protected function _updateBatch(string $table, array $values, string $index): string
     {
-        $keys = array_keys(current($values));
+        // this is a work around until the rest of the platform is refactored
+        $this->QBOptions['constraints'] = [$index];
+        $keys                           = array_keys(current($values));
 
-        // make array for future use with composite keys - `field`
-        // future: $this->QBOptions['constraints']
-        $constraints = [$index];
+        $sql = $this->QBOptions['sql'] ?? '';
 
-        // future: $this->QBOptions['updateFields']
-        $updateFields = array_filter($keys, static fn ($index) => ! in_array($index, $constraints, true));
+        // if this is the first iteration of batch then we need to build skeleton sql
+        if ($sql === '') {
+            $constraints = $this->QBOptions['constraints'] ?? [];
 
-        // Oracle doesn't support ignore on updates so we will use MERGE
-        $sql = 'MERGE INTO ' . $table . " \"t\"\n";
+            if ($constraints === []) {
+                if ($this->db->DBDebug) {
+                    throw new DatabaseException('You must specify a constraint to match on for batch updates.');
+                }
+
+                return ''; // @codeCoverageIgnore
+            }
+
+            $updateFields = $this->QBOptions['updateFields'] ??
+                $this->updateFields($keys, false, $constraints)->QBOptions['updateFields'] ??
+                [];
+
+            $alias = $this->QBOptions['alias'] ?? '"_u"';
 
-        $sql .= 'USING (' . "\n";
+            // Oracle doesn't support ignore on updates so we will use MERGE
+            $sql = 'MERGE INTO ' . $table . "\n";
 
-        $sql .= implode(
-            " UNION ALL\n",
-            array_map(
-                static fn ($value) => 'SELECT ' . implode(', ', array_map(
-                    static fn ($key, $index) => $index . ' ' . $key,
-                    $keys,
-                    $value
-                )) . ' FROM DUAL',
-                $values
-            )
-        ) . "\n";
+            $sql .= 'USING (' . "\n%s";
 
-        $sql .= ') "u"' . "\n";
+            $sql .= ') ' . $alias . "\n";
 
-        $sql .= 'ON (' . implode(
-            ' AND ',
-            array_map(static fn ($key) => '"t".' . $key . ' = "u".' . $key, $constraints)
-        ) . ")\n";
+            $sql .= 'ON (' . implode(
+                ' AND ',
+                array_map(
+                    static fn ($key) => ($key instanceof RawSql ?
+                    $key :
+                    $table . '.' . $key . ' = ' . $alias . '.' . $key),
+                    $constraints
+                )
+            ) . ")\n";
 
-        $sql .= "WHEN MATCHED THEN UPDATE\n";
+            $sql .= "WHEN MATCHED THEN UPDATE\n";
 
-        $sql .= 'SET' . "\n";
+            $sql .= 'SET' . "\n";
+
+            $sql .= implode(
+                ",\n",
+                array_map(
+                    static fn ($key, $value) => $table . '.' . $key . ($value instanceof RawSql ?
+                    ' = ' . $value :
+                    ' = ' . $alias . '.' . $value),
+                    array_keys($updateFields),
+                    $updateFields
+                )
+            );
+
+            $this->QBOptions['sql'] = $sql;
+        }
+
+        if (isset($this->QBOptions['fromQuery'])) {
+            $data = $this->QBOptions['fromQuery'];
+        } else {
+            $data = implode(
+                " UNION ALL\n",
+                array_map(
+                    static fn ($value) => 'SELECT ' . implode(', ', array_map(
+                        static fn ($key, $index) => $index . ' ' . $key,
+                        $keys,
+                        $value
+                    )) . ' FROM DUAL',
+                    $values
+                )
+            ) . "\n";
+        }
 
-        return $sql .= implode(
-            ",\n",
-            array_map(static fn ($key) => '"t".' . $key . ' = "u".' . $key, $updateFields)
-        );
+        return sprintf($sql, $data);
     }
 }