refactor: fix TypeError in ShowTableInfo::setYesOrNo()

kenjis · kenjis · commit 1497faf0a592 · 2023-11-29T06:58:46.000+09:00
1) CodeIgniter\Commands\Database\ShowTableInfoTest::testDbTableMetadata TypeError: CodeIgniter\Commands\Database\ShowTableInfo::setYesOrNo(): Argument #1 ($fieldValue) must be of type bool, int given, called in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Commands/Database/ShowTableInfo.php on line 286 /home/runner/work/CodeIgniter4/CodeIgniter4/system/Commands/Database/ShowTableInfo.php:297 /home/runner/work/CodeIgniter4/CodeIgniter4/system/Commands/Database/ShowTableInfo.php:286 /home/runner/work/CodeIgniter4/CodeIgniter4/system/Commands/Database/ShowTableInfo.php:144 /home/runner/work/CodeIgniter4/CodeIgniter4/system/CLI/Commands.php:67 /home/runner/work/CodeIgniter4/CodeIgniter4/system/Common.php:198 /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Commands/Database/ShowTableInfoTest.php:98
diff --git a/system/Commands/Database/ShowTableInfo.php b/system/Commands/Database/ShowTableInfo.php
@@ -294,9 +294,12 @@ private function showFieldMetaData(string $tableName): void
         CLI::table($this->tbody, $thead);
     }
 
-    private function setYesOrNo(bool $fieldValue): string
+    /**
+     * @param bool|int|string|null $fieldValue
+     */
+    private function setYesOrNo($fieldValue): string
     {
-        if ($fieldValue) {
+        if ((bool) $fieldValue) {
             return CLI::color('Yes', 'green');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -294,9 +294,12 @@ private function showFieldMetaData(string $tableName): void`
`294`	`294`	`CLI::table($this->tbody, $thead);`
`295`	`295`	`}`
`296`	`296`
`297`		`- private function setYesOrNo(bool $fieldValue): string`
	`297`	`+ /**`
	`298`	`+ * @param bool\|int\|string\|null $fieldValue`
	`299`	`+ */`
	`300`	`+ private function setYesOrNo($fieldValue): string`
`298`	`301`	`{`
`299`		`- if ($fieldValue) {`
	`302`	`+ if ((bool) $fieldValue) {`
`300`	`303`	`return CLI::color('Yes', 'green');`
`301`	`304`	`}`
`302`	`305`