test: refactor with data provider

Author: kenjis

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -50,63 +50,6 @@ protected function getInstance($options = [])
         return new RedisHandler($sessionConfig, $this->userIpAddress);
     }
 
-    public function testSavePathWithoutProtocol(): void
-    {
-        $handler = $this->getInstance(
-            ['savePath' => '127.0.0.1:6379']
-        );
-
-        $savePath = $this->getPrivateProperty($handler, 'savePath');
-
-        $this->assertSame('tcp', $savePath['protocol']);
-    }
-
-    public function testSavePathTLSAuth(): void
-    {
-        $handler = $this->getInstance(
-            ['savePath' => 'tls://127.0.0.1:6379?auth=password']
-        );
-
-        $savePath = $this->getPrivateProperty($handler, 'savePath');
-
-        $this->assertSame('tls', $savePath['protocol']);
-        $this->assertSame('password', $savePath['password']);
-    }
-
-    public function testSavePathTCPAuth(): void
-    {
-        $handler = $this->getInstance(
-            ['savePath' => 'tcp://127.0.0.1:6379?auth=password']
-        );
-
-        $savePath = $this->getPrivateProperty($handler, 'savePath');
-
-        $this->assertSame('tcp', $savePath['protocol']);
-        $this->assertSame('password', $savePath['password']);
-    }
-
-    public function testSavePathTimeoutFloat(): void
-    {
-        $handler = $this->getInstance(
-            ['savePath' => 'tcp://127.0.0.1:6379?timeout=2.5']
-        );
-
-        $savePath = $this->getPrivateProperty($handler, 'savePath');
-
-        $this->assertEqualsWithDelta(2.5, $savePath['timeout'], PHP_FLOAT_EPSILON);
-    }
-
-    public function testSavePathTimeoutInt(): void
-    {
-        $handler = $this->getInstance(
-            ['savePath' => 'tcp://127.0.0.1:6379?timeout=10']
-        );
-
-        $savePath = $this->getPrivateProperty($handler, 'savePath');
-
-        $this->assertEqualsWithDelta(10.0, $savePath['timeout'], PHP_FLOAT_EPSILON);
-    }
-
     public function testOpen(): void
     {
         $handler = $this->getInstance();
@@ -190,4 +133,73 @@ public function testSecondaryReadAfterClose(): void
 
         $handler->close();
     }
+
+    /**
+     * @dataProvider provideSetSavePath
+     */
+    public function testSetSavePath(string $savePath, array $expected): void
+    {
+        $option  = ['savePath' => $savePath];
+        $handler = $this->getInstance($option);
+
+        $savePath = $this->getPrivateProperty($handler, 'savePath');
+
+        $this->assertSame($expected, $savePath);
+    }
+
+    public static function provideSetSavePath(): iterable
+    {
+        yield from [
+            'w/o protocol' => [
+                '127.0.0.1:6379',
+                [
+                    'host'     => 'tcp://127.0.0.1',
+                    'port'     => 6379,
+                    'password' => null,
+                    'database' => 0,
+                    'timeout'  => 0.0,
+                ],
+            ],
+            'tls auth' => [
+                'tls://127.0.0.1:6379?auth=password',
+                [
+                    'host'     => 'tls://127.0.0.1',
+                    'port'     => 6379,
+                    'password' => 'password',
+                    'database' => 0,
+                    'timeout'  => 0.0,
+                ],
+            ],
+            'tcp auth' => [
+                'tcp://127.0.0.1:6379?auth=password',
+                [
+                    'host'     => 'tcp://127.0.0.1',
+                    'port'     => 6379,
+                    'password' => 'password',
+                    'database' => 0,
+                    'timeout'  => 0.0,
+                ],
+            ],
+            'timeout float' => [
+                'tcp://127.0.0.1:6379?timeout=2.5',
+                [
+                    'host'     => 'tcp://127.0.0.1',
+                    'port'     => 6379,
+                    'password' => null,
+                    'database' => 0,
+                    'timeout'  => 2.5,
+                ],
+            ],
+            'timeout int' => [
+                'tcp://127.0.0.1:6379?timeout=10',
+                [
+                    'host'     => 'tcp://127.0.0.1',
+                    'port'     => 6379,
+                    'password' => null,
+                    'database' => 0,
+                    'timeout'  => 10.0,
+                ],
+            ],
+        ];
+    }
 }