Merge pull request #6826 from kenjis/change-default-timezone

config: change default timezone to UTC

Author: kenjis

app/Config/App.php

@@ -97,7 +97,7 @@ class App extends BaseConfig
      * The default timezone that will be used in your application to display
      * dates with the date helper, and can be retrieved through app_timezone()
      */
-    public string $appTimezone = 'America/Chicago';
+    public string $appTimezone = 'UTC';
 
     /**
      * --------------------------------------------------------------------------

tests/system/CommonFunctionsTest.php

@@ -316,7 +316,7 @@ public function testInvisibleEncoded()
 
     public function testAppTimezone()
     {
-        $this->assertSame('America/Chicago', app_timezone());
+        $this->assertSame('UTC', app_timezone());
     }
 
     public function testCSRFToken()

tests/system/Debug/TimerTest.php

@@ -94,6 +94,10 @@ public function testThrowsExceptionStoppingNonTimer()
         $timer->stop('test1');
     }
 
+    /**
+     * This test might fail if your timezone has Daylight Saving Time.
+     * See https://github.com/codeigniter4/CodeIgniter4/issues/6823
+     */
     public function testLongExecutionTime()
     {
         $timer = new Timer();

tests/system/I18n/TimeLegacyTest.php

@@ -453,9 +453,10 @@ public function testGetQuarter()
     public function testGetDST()
     {
         // America/Chicago. DST from early March -> early Nov
-        $time = TimeLegacy::createFromDate(2012, 1, 1);
+        $time = TimeLegacy::createFromDate(2012, 1, 1, 'America/Chicago');
         $this->assertFalse($time->dst);
-        $time = TimeLegacy::createFromDate(2012, 9, 1);
+
+        $time = TimeLegacy::createFromDate(2012, 9, 1, 'America/Chicago');
         $this->assertTrue($time->dst);
     }
 

tests/system/I18n/TimeTest.php

@@ -398,6 +398,10 @@ public function testGetTimestamp()
         $this->assertSame($expected, $time->timestamp);
     }
 
+    /**
+     * This test might fail if your timezone has Daylight Saving Time.
+     * See https://github.com/codeigniter4/CodeIgniter4/issues/6818
+     */
     public function testGetAge()
     {
         $time = Time::parse('5 years ago');
@@ -455,9 +459,10 @@ public function testGetQuarter()
     public function testGetDST()
     {
         // America/Chicago. DST from early March -> early Nov
-        $time = Time::createFromDate(2012, 1, 1);
+        $time = Time::createFromDate(2012, 1, 1, 'America/Chicago');
         $this->assertFalse($time->dst);
-        $time = Time::createFromDate(2012, 9, 1);
+
+        $time = Time::createFromDate(2012, 9, 1, 'America/Chicago');
         $this->assertTrue($time->dst);
     }
 

user_guide_src/source/changelogs/v4.3.0.rst

@@ -264,6 +264,7 @@ Changes
 - Config
     - All atomic type properties in ``Config`` classes have been typed.
     - Changed the default setting to not redirect when a CSRF check fails so that it is easy to see that it is a CSRF error.
+    - The default ``Config\App::$appTimezone`` has been changed to ``UTC`` to avoid being affected by daylight saving time.
 - DBDebug
     - To be consistent in behavior regardless of environments, ``Config\Database::$default['DBDebug']`` and ``Config\Database::$tests['DBDebug']`` has been changed to ``true`` by default. With these settings, an exception is always thrown when a database error occurs.
     - Now ``DatabaseException`` thrown in ``BaseBuilder`` is thrown if ``$DBDebug`` is true. Previously, it is thrown if ``CI_DEBUG`` is true.