refactor: simplify if condition

kenjis · kenjis · commit 4c0149939f8f · 2024-06-18T10:00:26.000+09:00
diff --git a/system/Database/BaseBuilder.php b/system/Database/BaseBuilder.php
@@ -1464,7 +1464,7 @@ public function orderBy(string $orderBy, string $direction = '', ?bool $escape =
             $direction = in_array($direction, ['ASC', 'DESC'], true) ? ' ' . $direction : '';
         }
 
-        if (! is_bool($escape)) {
+        if ($escape === null) {
             $escape = $this->db->protectIdentifiers;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1464,7 +1464,7 @@ public function orderBy(string $orderBy, string $direction = '', ?bool $escape =`
`1464`	`1464`	`$direction = in_array($direction, ['ASC', 'DESC'], true) ? ' ' . $direction : '';`
`1465`	`1465`	`}`
`1466`	`1466`
`1467`		`- if (! is_bool($escape)) {`
	`1467`	`+ if ($escape === null) {`
`1468`	`1468`	`$escape = $this->db->protectIdentifiers;`
`1469`	`1469`	`}`
`1470`	`1470`