refactor: more preg_match() and empty string only check

samsonasik · samsonasik · commit 4c5daaf615d2 · 2024-12-28T21:43:08.000+07:00
diff --git a/system/Test/CIUnitTestCase.php b/system/Test/CIUnitTestCase.php
@@ -374,7 +374,7 @@ public function assertLogContains(string $level, string $logMessage, string $mes
     {
         $this->assertTrue(
             TestLogger::didLog($level, $logMessage, false),
-            $message !== '' && $message !== '0' ? $message : sprintf(
+            $message !== '' ? $message : sprintf(
                 'Failed asserting that logs have a record of message containing "%s" with level "%s".',
                 $logMessage,
                 $level

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ public function assertLogContains(string $level, string $logMessage, string $mes`
`374`	`374`	`{`
`375`	`375`	`$this->assertTrue(`
`376`	`376`	`TestLogger::didLog($level, $logMessage, false),`
`377`		`- $message !== '' && $message !== '0' ? $message : sprintf(`
	`377`	`+ $message !== '' ? $message : sprintf(`
`378`	`378`	`'Failed asserting that logs have a record of message containing "%s" with level "%s".',`
`379`	`379`	`$logMessage,`
`380`	`380`	`$level`