Merge pull request #8565 from kenjis/refactor-Model-useCasts

[4.5] refactor: use local variables in Model

Author: kenjis

system/Model.php

@@ -186,7 +186,8 @@ protected function doFind(bool $singleton, $id = null)
     {
         $builder = $this->builder();
 
-        if ($this->useCasts()) {
+        $useCast = $this->useCasts();
+        if ($useCast) {
             $returnType = $this->tempReturnType;
             $this->asArray();
         }
@@ -207,7 +208,7 @@ protected function doFind(bool $singleton, $id = null)
             $row = $builder->get()->getResult($this->tempReturnType);
         }
 
-        if ($this->useCasts()) {
+        if ($useCast) {
             $row = $this->convertToReturnType($row, $returnType);
 
             $this->tempReturnType = $returnType;
@@ -257,7 +258,8 @@ protected function doFindAll(?int $limit = null, int $offset = 0)
 
         $builder = $this->builder();
 
-        if ($this->useCasts()) {
+        $useCast = $this->useCasts();
+        if ($useCast) {
             $returnType = $this->tempReturnType;
             $this->asArray();
         }
@@ -270,7 +272,7 @@ protected function doFindAll(?int $limit = null, int $offset = 0)
             ->get()
             ->getResult($this->tempReturnType);
 
-        if ($this->useCasts()) {
+        if ($useCast) {
             foreach ($results as $i => $row) {
                 $results[$i] = $this->convertToReturnType($row, $returnType);
             }
@@ -293,7 +295,8 @@ protected function doFirst()
     {
         $builder = $this->builder();
 
-        if ($this->useCasts()) {
+        $useCast = $this->useCasts();
+        if ($useCast) {
             $returnType = $this->tempReturnType;
             $this->asArray();
         }
@@ -312,7 +315,7 @@ protected function doFirst()
 
         $row = $builder->limit(1, 0)->get()->getFirstRow($this->tempReturnType);
 
-        if ($this->useCasts()) {
+        if ($useCast) {
             $row = $this->convertToReturnType($row, $returnType);
 
             $this->tempReturnType = $returnType;